429 too many emoji requests 😥

Supporto
1

After opening the emoji selector in the post editor, discourse throws users out once they load a page again (like after submitting a post).

429 Too Many Requests

Your IP address has made too many requests to this service over a short amount of time. Please wait a few minutes and try again.

If you are behind a proxy or coming from a large company, you and many other users may appear to be the same person. Please let us know of recurring problems by email: team@discourse.org

It seems it was not the user trying to DDOS discourse, but discourse itself. If there is a way, maybe distinct requests to resources (like emojis) should not be considered? Or all emojis should be combined into a sprite?

2

Very little point in that cause we have HTTP/2

Can you clarify, is this happening on meta.discourse.org or on some other site we are hosting?

If it’s on meta then yes we got to add a bypass to our special rate limiting here for emojis, discourse_docker/templates/web.ratelimited.template.yml at master · discourse/discourse_docker · GitHub is too indescriminent.

One plan we have is to shift to a global rate limit in the APP so this would be totally sidestepped and then the NGINX rate limit can be way higher.

3

You will need to clarify this part first @Fredo.

4

It’s hosted by discourse (https://forums.sketchup.com/). But you have to scroll quickly through all the emojis to reproduce it.

5

FTR I was able to reproduce it on https://forums.sketchup.com by scrolling through the emojis.

7

I am leaving this assigned to me for now, we do plan to improve this in 2 ways

  1. whitelist emoji requests from the CDN so they do not participate in the rate limiting

  2. centralize emoji storage across all our sites so there is only one CDN for emojis.

8

We need to centralize emoji paths and avatar paths (on Discourse hosting). So this is a to-do we still need to get to.

9

Abbiamo fatto molto qui per migliorare la situazione: regole migliori per il nostro CDN, limiti più flessibili per le emoji.

La soluzione fondamentale di utilizzare un’unica posizione per tutte le emoji non è ancora stata implementata e non prevediamo di pianificarla nel prossimo futuro a causa dell’enormità di un tale cambiamento.

11

Dato che non c’è stato alcun evento recente di questo tipo, penso che possiamo considerarlo risolto. :slight_smile: