Une modale de confirmation de suppression apparaît lors du clic sur « Nouveau message » si un message est en attente d'approbation

zogstrip · Mars 25, 2026, 2:10

J’ai une correction en cours - @martin, qu’en pensez-vous ?

github.com/discourse/discourse

FIX: Discard draft modal shown after submitting post for approval (#38870)

main ← fix/discard-draft-modal-after-enqueued-post

opened 02:09PM - 25 Mar 26 UTC

ZogStriP

+39 -1

When creating a new topic in a category that requires approval, the composer wou…ld show a "discard draft" modal on every subsequent attempt to open it (new topic or reply). The issue was in the post-enqueue handler in the composer service. After a post is enqueued, the code tries to push the pending post into `this.topicController.model.pending_posts`. When creating a new topic, the user is on the topic list — not viewing a topic — so `this.topicController.model` is undefined. Accessing `.pending_posts` on undefined throws a TypeError, which prevents `destroyDraft()` and `close()` from ever executing. The composer model stays on the service with dirty content, so any subsequent composer open triggers the discard draft modal. The fix adds optional chaining (`?.`) so the pending_posts push is safely skipped when no topic model is loaded. https://meta.discourse.org/t/397711

Sujet		Réponses	Vues
"do you want to discard your post ?" UX composer , fixed	1	111	Avril 8, 2026
Ask a user to revise their post before approving it? Feature approval , completed	11	1462	Février 28, 2024
Allow the ability to Edit post on rejection UX review-queue	21	393	Mai 6, 2026
Users can see pending/rejected topics Feature completed	6	1508	Janvier 18, 2022
What Happens to Posts that are not Approved? Support	3	2444	Avril 23, 2020

Une modale de confirmation de suppression apparaît lors du clic sur « Nouveau message » si un message est en attente d'approbation

Sujets connexes