ActivityPub plugin: stack level too deep

Contribute Bug

AI-generated summary

The discussion revolves around the ActivityPub plugin error “stack level too deep” in the logs. pmusaraj initially reported the issue, providing a backtrace that pointed to the base_object_id method in json_ld.rb. [Jagster](/t/-/354445/2, /t/-/354445/3) also experienced the error, with hundreds of incidents, but couldn’t identify any visible issues. The error was caused by an infinite recursion in the base_object_id method. angus addressed the issue with a pull request, which was merged. According to angus, the error was related to protecting against duplicate activities being sent in quick succession, but since Jagster didn’t notice any issues, it’s likely that their server wasn’t federating with a server that sends duplicate activities.

1

Getting this error in logs recently (past 4-5 days):

Message (18 copies reported)

Job exception: stack level too deep
Backtrace

activesupport-7.2.2.1/lib/active_support/core_ext/object/blank.rb:166:in `present?'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:57:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'

Env doesn’t have much info around the object:

|queue|default|
|---|---|
|class|Jobs::DiscourseActivityPubProcess|
|args|[object Object], []|
1 Like
2

I have 970 incidents of that under some timeperiod. Everyday few, anyway. I can’t see any real visible issues, though.

(And now I’ve started get some strange deadlock things, but that would be worth of own topic)

1 Like
3

I still get this, but I can’t tell how do I get it.

I know this much. Or little.

One log incident repeats this line really many times. I don’t know how many, because scrolling started hurt my wrist.

/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'

I don’t like that tick becore base_object_id

It show a link icon and it is leading to GitHub 404.

https://github.com/discourse/discourse/blob/3165992a90c481e5aa6fb1b18854cf7d9c3ed791/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb#L58

That doesn’t mean anything, right? In that branch isn’t acitivity-pub directory, but why it shows that? I’m just curious.

4

I missed this somehow! Apologies, this should address it.

https://github.com/discourse/discourse-activity-pub/pull/198

1 Like
5

Thanks @angus :+1: It’s been merged.

2 Likes
6

Thanks.

Very 101-question, because I’m curious. I couldn’t see anything suspicious anywhere, and all it did was just annoying error in logs. Did that error something… real?

7

It was used in code that protected against duplicate activities being sent in quick succession, which some other platforms do from time to time. So if you didn’t notice anything, you’re not federating with a server that does that.

2 Likes