ActivityPub plugin: stack level too deep

[pmusaraj (Penar Musaraj)]

Getting this error in logs recently (past 4-5 days):

Message (18 copies reported)

Job exception: stack level too deep
Backtrace

activesupport-7.2.2.1/lib/active_support/core_ext/object/blank.rb:166:in `present?'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:57:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'  
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'  

Env doesn’t have much info around the object:

|queue|default|
|---|---|
|class|Jobs::DiscourseActivityPubProcess|
|args|[object Object], []|

[Jagster (Jakke Lehtonen)]

I have 970 incidents of that under some timeperiod. Everyday few, anyway. I can’t see any real visible issues, though.

(And now I’ve started get some strange deadlock things, but that would be worth of own topic)

[Jagster (Jakke Lehtonen)]

I still get this, but I can’t tell how do I get it.

I know this much. Or little.

One log incident repeats this line really many times. I don’t know how many, because scrolling started hurt my wrist.

/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb:58:in `base_object_id'

I don’t like that tick becore base_object_id

It show a link icon and it is leading to GitHub 404.

https://github.com/discourse/discourse/blob/3165992a90c481e5aa6fb1b18854cf7d9c3ed791/plugins/discourse-activity-pub/lib/discourse_activity_pub/json_ld.rb#L58

That doesn’t mean anything, right? In that branch isn’t acitivity-pub directory, but why it shows that? I’m just curious.

[angus (Angus McLeod)]

I missed this somehow! Apologies, this should address it.

FIX: improve base_object_id parsing

[zogstrip (Régis Hanol)]

Thanks @angus It’s been merged.

[Jagster (Jakke Lehtonen)]

Thanks.

Very 101-question, because I’m curious. I couldn’t see anything suspicious anywhere, and all it did was just annoying error in logs. Did that error something… real?

[angus (Angus McLeod)]

It was used in code that protected against duplicate activities being sent in quick succession, which some other platforms do from time to time. So if you didn’t notice anything, you’re not federating with a server that does that.