Add ability to Embed GitLab Onebox by displaying the code inside like GitHub Does in Discourse.
Gitlab needs to support it. Onebox probably has nothing to do with it.
Have you checked how they render on iframely?
I’m not so sure. Gitlab is similar to Github, which has its own onebox engine/rule
So github is treated differently?
Yes. It has a few custom engines to one box it’s urls
Oh okay! I was unaware of it.
We’d be happy to support a PR that adds custom onebox behaviors for GitLab.
A plugin as well:
This is very cool, but I feel like we should just fold it all into onebox, no need to add one more plugin here.
Can you show some screenshots of how it looks?
Excellent work @misaka4e21!
The plugin will only be necessary when the pull request is not merged. All things in the plugin are included in the PR.
(It seems that the GitHub icon is wrongly displayed.)
cool lets get the icon sorted as well, also the spacing the the gutter looks really big.
The GitHub favicon is now removed for GitLab. The independent icon of GitLab should be added to the discourse
onebox.scssand assets instead of the onebox repo, in order to be shown.
As for the spacing issue, it is the same as current GitHub ones.
Hmm, this only supports gitlab.com urls, not other domains?
Here’s an example:
Yes it currently supports only gitlab.com.
Should we match any URL with pattern
/<user>/<repo>/blob/<branch|commit>/<path> without checking it to be a GitLab instance?
And, there is also other git hosting platform, such as gogs: libreCMC/libreCMC @ v1.4 - libreCMC
I searched for identifying elements, and there’s nothing good in the
body[data-page="projects:blob:show"] might be a good one.
Of cousre, Discourse has
<meta name="generator" content="Discourse...">
gitlab.com only for now is fine, we can further refine it later.