%{name} Variable zum BCC-Plugin hinzufügen

[nathank (Nathan Kershaw)]

This is for the official Bcc plugin.

Suggestion 1

Could we please have {name} as well as {username}? Using a real name is a lot more personal in forums where that is acceptable.

Suggestion 2

Have you considered bringing the UX/sentax in line with the (also official) Discourse Canned Replies plugin? For example, using the following instead of {username} and {@username}:

1. %{username}
2. %{@username}

and if applying my first suggestion:

1. %{name}

Cc @Qursch

[Qursch]

These both sound like good suggestions. I’ll start working on them this weekend.
Edit: PR was created.

https://github.com/discourse/discourse-bcc/pull/9

[nathank (Nathan Kershaw)]

Good stuff! But on testing I’ve noticed that the old problem has recurred and we have the name of the first recipient appearing in all subsequent messages - yikes! It is the same as:

Bcc plugin placeholders not working

The Discourse-bcc plugin’s new feature has a glitch. When I write this message from the user NathanK to my two test users, the placeholder only seems to work on the first user: [image] This is what I get for the first user, which is sweet: [image] However, this is what I get for the second user (note that the username is the first user’s): [image]

I must be the only one actually using this feature at the mo!!

[Qursch]

Just created a PR with what seems to be the fix, but I am unsure of why adding name personalization would break this as it was working before.

[nathank (Nathan Kershaw)]

You are awesome! I’ll kick the tires once it is merged.

Hey, I realised something else that was wrong with my Name suggestion above - we actually need Firstname. Do you reckon it is possible to just use the first word of the string?

I could do that in Excel but no idea in Ruby!!!

[Qursch]

Thanks, just trying to conrtibute where I can. I’ll actually add additional options for %{first_name} and %{last_name}, and change the existing to be full name.

[nathank (Nathan Kershaw)]

How did you get on?

From Fix personalization (#11) · discourse/discourse-bcc@74442fd · GitHub it looks like the %{first_name} thing didn’t fly but you have fixed the bug.

P.S. do you like my nice Bug Reporter title? They say that imitation is the highest form of flattery!

[Qursch]

Yeah, the bug should be fixed (I tested it repeatedly). In regards to first and last names, there can be no “one method fits all” as Discourse doesn’t have a separate field for first and last names, only one overall.

[nathank (Nathan Kershaw)]

Great work!!!

(not so sure that Gifs in Discourse is a great idea but saw it and couldn’t resist)

@Qursch

Discourse doesn’t have a separate field for first and last names, only one overall.

Yeah I know - it would require some clever code to split the string if it contained a space, only retaining the characters up until the space. And just using the whole string if there is no space.

Like I said, I can do that in Excel but not Javascript / Ruby!