shoshber
(Shoshana Berleant)
26 Marzo 2018, 8:30pm
1
I need to modify a javascript controller (create-account). If I were writing it from scratch, I’d add a mixin called something like (FooValidation), the same way the mixins PasswordValidation and UsernameValidation are applied (discourse/app/assets/javascripts/discourse/controllers/create-account.js.es6 at f03b6bd8c925163b41b9e33b39484d102dbaee44 · discourse/discourse · GitHub ). I can’t figure out how, though.
I could just add the relevant properties/methods to the create account controller using PluginApi.modifyClass, but that doesn’t feel right, especially seeing as I’ll want to reuse the mixin.
What’s the best way to achieve this?
Osama
26 Marzo 2018, 9:57pm
2
I believe the modifyClass method accepts a mixin as an argument, so I’d try something like this:
api.modifyClass("controller:create-account", FooValidation);
shoshber
(Shoshana Berleant)
27 Marzo 2018, 8:11pm
3
Ah you’re right, modifyClass calls Ember’s reopen, which can take mixins as an argument. I couldn’t get it to work at first but I got it! Thanks!
Dev_Work
(Aleksandr)
17 Dicembre 2019, 8:32pm
4
Puoi condividere del codice di esempio?
merefield
(Robert)
17 Dicembre 2019, 10:03pm
5
Lo faccio in Topic List Previews: https://github.com/paviliondev/discourse-topic-previews/blob/master/assets/javascripts/discourse/initializers/preview-edits.js.es6
Esempio specifico: api.modifyClass('component:topic-list', Settings);
L’ho fatto per separare il codice condiviso che altrimenti sarebbe stato ripetuto e quasi un semplice copia-incolla.