Alert used to Notify AutoComplete Support?

Dev
1

Should this really be an alert? Or can it be a console.log entry?
https://github.com/discourse/discourse/blob/510f9c5bedbb567c5ce9178e203c5d817731e655/app/assets/javascripts/discourse/lib/autocomplete.js.es6#L61-L63

I’m noticing it appearing on the Poll UI Plugin because I embed the editor in a Modal, while it is still open in on the topic/create new topic.

It initially took me by surprise because I wasn’t sure what “only supporting one matcher at the moment” meant, it would be nice if this were 1) more specific, such as, “AutoComplete: only supporting one matcher in an editor at the moment” and 2) a console.log statement, since it isn’t really breaking anything (from what I can tell).

1 Like
2

Related to this:

1 Like
3

Thanks. I can’t believe I didn’t catch that. Guess I just got caught up with looking in the dev category :slightly_smiling:

1 Like
4

Alert seems really odd here we should change it to a log keeping in mind IE has no console object

@tgxworld perhaps have a look at this

2 Likes
5

Cleaned up per:

1 Like