Todos os e-mails desativados após restaurar o backup?

Contribuir Funcionalidade
1

I wanted to do some testing with Discourse so I took a backup of my instance, wiped the DB (rm -fr /var/discourse/shared) and rebuilt the container.

I then created an admin user again and instead of following the setup wizard I went straight to admin, enabled restores, uploaded the backup and restored.

For whatever reason the outgoing email is disabled by an administrator message appeared.

I can confirm that the outgoing email was never disabled on the instance where the backup was made.

I did tick the option to enable readonly mode when performing backup operations.

Is this a bug or did I mess up somewhere?

2 curtidas
After restore, sending email invites don't work
2

Você deve ver essa mensagem apenas por um curto período. Ela deve desaparecer assim que a restauração for concluída, desde que os e-mails de saída não tenham sido desativados no momento da criação do backup. Se a mensagem não desaparecer automaticamente, atualizar a página no seu navegador deve ajudar.

Deixo isso como Contribute > Bug, porque a maneira como atualmente desativamos os e-mails de saída antes da restauração é bastante inútil. O Sidekiq é desativado durante a restauração, portanto, nada pode acontecer nesse período. Além disso, a restauração sobrescreve o valor da configuração disable_email. Corrigir o bug exigiria alterar a configuração do site após a restauração.

@eviltrout Você adicionou isso em When restoring a backup, disable emails. · discourse/discourse@ccf9b70 · GitHub. Qual é a sua opinião sobre isso? Devemos corrigir o bug ou remover o código? Na minha opinião, alterar uma configuração do site após a restauração seria bastante inesperado, então voto pela remoção. Além disso, ninguém reclamou desse problema em quase 3 anos… :wink:

3 curtidas
3

I think the idea was that when a restore finishes the administrator might want to poke around and make sure everything is OK. Right now emails will start going out the second it finishes and the site might not be “approved.”

4 curtidas
4

So therefore this is not a bug @gerhard

5

Maybe Discourse should make it a bit more clear to the admin (e.g. entry inserted in the backup log panel). The site setting for disable_emails is set to no while the message renders and this is confusing (admin panel says disable emails is off while the message on the top of the screen still says its disabled)

6

Well, I consider it a bug when a line of code doesn’t do what it’s supposed to do. :wink: Anyway, it’s fixed: FIX: Outgoing emails were not disabled after restoring backup · discourse/discourse@dc961fe · GitHub

I made a small adjustment, because I think it’s better to disable outgoing emails only for non-staff users instead of all of them.

7 curtidas
7

This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.