Allow reply-to individual instead of topic/forum (mailing list feature)

Supporto
41

Thanks Tarek!

Can you remove the reply all button change?

My second point is just that there is no reply to sender functionality. If I were to hit reply it would go to discourse, not directly to the sender by email, bypassing diacourse. Make sense?

42

try editing this file:

https://github.com/tareko/discourse-replyto-individual/blob/master/config/locales/client.en.yml

43

thanks, tarek! what about the second point? if I’m right then there’s no need for me even to have this plugin turned on. Mailing list mode seems to not be affected.

I’ll watch it for a few days and let you know what happens. :rocket:

44

I’m not sure how that comes to pass for you. For me, obviously it works as advertised. Did you perhaps not enable the plugin? settings > plugins > replyto-individual enabled

45

yep - it’s enabled.

does the plugin work with mailing list mode turned on?

46

Yes. Not sure what’s happening on your installation there.

47

ok - we’ll let it play out for a few days. it’s a quiet, new forum and there haven’t been any posts since I enabled your plugin.

I did update just now to change them as follows - but the topic button still says “reply all” not “reply”.

Screen Shot 2016-11-22 at 8.56.07 PM.png1490×250 46.4 KB

48

Hello all,

For those using this plugin, it is currently known to be broken. I’m working on fixing it at the moment.

4 Mi Piace
49

Did it break a while ago, or did 2.1.2 break it? Wondering if I should hold off upgrading.

50

It broke in ~ August. It’s now fixed, so go ahead.

51

The plugin is now working again. Here’s the issue if for some reason one is bored and interested:

https://github.com/tareko/discourse-replyto-individual/issues/1

1 Mi Piace
52

I spoke too soon about this bug being fixed. For some reason, I cannot get a “Reply-To” header added into my email properly.

The current lines in question are these:

      if allow_reply_by_email?
        result[ALLOW_REPLY_BY_EMAIL_HEADER] = true
        if @opts[:private_reply] == true
          result['Reply-To'] = reply_by_email_address
        else
          p = Post.find_by_id @opts[:post_id]
          result['Reply-To'] = "#{p.user.name} <#{p.user.email}>"
          result['CC'] = reply_by_email_address
        end
      else
        result['Reply-To'] = from_value
end

This section is taken from the Email::MessageBuilder class.

If I leave the Reply-To set to its default ( reply_by_email_address), then all is well. However, if it is set to anything else (even “test@test.com”, then it will simply disappear from the end email headers. Similarly, if I replace Reply-To with something else like CC, then for some reason it does not build, and instead displays: replies+%{reply_key}@emlondon.ca (note, the %{reply_key} is correctly fixed in the Reply-To.

I really have no idea a) why this behaviour is happening; and b) Why it’s happening now after working for so long - what am I missing here in the API?

1 Mi Piace
53

I managed to fix the problem with the reply_key not being substituted using this commit, which modifies the set_reply_key method in the Email::Sender class. However, I still can’t figure out why Reply-To becomes null when I change it to anything but ‘reply_by_email_address’. It is set correctly at the end of the header_args method, but I can’t figure out where it is unset.

Any thoughts? I think @featheredtoast is the staff member I see with the most recent edits to Email::MessageBuilder

Edit: After some debugging, this appears to happen somewhere in lib/mail/sender.rb before line 86, though not sure exactly where…

Edit #2: After further debugging, I found the problem to be the following line in the Email::Sender::set_reply_key method:

      @message.header['Reply-To'] =
        header_value('Reply-To').gsub!("%{reply_key}", reply_key)

This method was causing a Reply-To without a reply_key to be wiped. I added a simple if statement to exclude the function if there was no “reply_key” in it. As of this moment, the plugin is back to fully working status.

1 Mi Piace
55

I suppose a recent Discourse upgrade broke the plugin. replies-xyz@example.com is no longer being cc’ed. I created an issue.

56

Mi scuso per il ritardo nel rispondere, per qualche motivo non ho ricevuto le notifiche. Seguirò questo problema su GitHub.

1 Mi Piace
57

Questo ora è stato corretto su GitHub. L’essenza è che ci sono stati alcuni cambiamenti nel modo in cui message_builder.rb e sender.rb facevano le loro cose che hanno annullato le modifiche dei plugin. Per esempio, è stato usato gsub! invece di gsub per la sostituzione di reply_key, il che ha annullato l’header ‘to’. Inoltre, per qualche motivo CC veniva annullato da self.custom_headers perché era di 2 caratteri. Forse una funzionalità di sicurezza da qualche parte? Ma l’ho disabilitata per far funzionare il modulo. La nuova versione è su github. Grazie per la segnalazione del bug!

1 Mi Piace