Android copy/paste menu covers quote reply button

خلل
1

Reproduce:

  1. On a device running Android 6.0.1 (Google Pixel C here), or iOS (thanks @codinghorror) open a Discourse topic.
  2. Highlight text you want to quote in your reply.
  3. Attempt to use the grey “Quote Reply” button.

Expected Results:

  • The quote reply button is available and works.

Actual Results:

  • The quote reply button is blocked by the Android copy/paste context menu, as shown in this image:

Screenshot_20160120-124651-01.jpeg1596×328 132 KB

3 إعجابات
2

Same issue on iOS, because of the popup above.

إعجاب واحد (1)
3

Still an issue

4

I remember at some point we moved this below, I wonder what happened

5

We should definitely move it below, we have no choice on mobile.

إعجاب واحد (1)
6

This looks moved to me now? Did you take this already @tgxworld?

7

Nope, try selecting one word, or starting at opposite dir

8

Still showing button below on my iPhone 6s… even when I select a single word on the same line…

9

On iPad safari

image.png2048×1536 227 KB

10

Not yet. Will look at it this week.

11

Yeah but that’s desktop not mobile layout. I have multiple screenshots of it doing below on the iPhone 6s.

So perhaps then the “fix” is “behave like mobile here in all cases and place the button below”.

إعجابَين (2)
12

Fixed!

https://github.com/discourse/discourse/blob/6dd6bbd5095659f46cfadc149d18902253c2eb02/app/assets/javascripts/discourse/controllers/quote-button.js.es6#L89-L94

إعجاب واحد (1)
13

Kind of – depends if we classify Android as “mobile” or not, which might be a problem for the few rare larger Android tablets… not a problem at the moment since we almost completely lump all Android devices into mobile, but may not be that way in the future, which would make the OP a bug again.

إعجابَين (2)
14

O wait I didn’t notice OP was on Android. Let me confirm.

15

Conceptually, I kinda think it should be

if (isMobileDevice || isIOS || isAndroid)

Since there are “not-mobile” devices in both categories, yes?

3 إعجابات
16

For your reference, this might be helpful:

إعجابَين (2)