Approve post in closed topic leads to internal server error

bug
1

Create a thread.
Try to post with an account with no enough permissions. The post will be up for approval.
Close the thread.
Try to approve the post leads to 500 Internal Server error popup.

Opening the thread again and approving the post worked.

Discourse 1.4.2

2

Can you update to latest and try again? We don’t usually fix bugs in old versions unless they are security issues.

2 Likes
3

It keeps happening on Discourse 1.5.2

1 Like
4

No, I meant on latest 1.6 beta code. That code is quite old. We don’t fix minor bugs in old versions unless they are security issues.

@techapj can you repro this?

5

I can repro this issue on latest verison. Added on my list. :pencil:

4 Likes
6

Yes, that is correct. If the topic is closed or deleted, approving the post (in that topic) should not work. I agree that error message can be improved. Done via:

https://github.com/discourse/discourse/commit/3232ce8265a72a8cca6058fbcf1e670d41dd158f

Now the error message will be:

Something has gone wrong. Perhaps this topic was closed or deleted while you were looking at it?

5 Likes