Plugin de Azure Blob Storage

sam · 7 Marzo, 2019 21:00

Awesome, @vinothkannans can you review and merge ?

AJRT · 23 Julio, 2019 15:33

Hello @maja

I have some issue, which could be related with this plugin.
There is more info about this issue:

Could you check if the problem is with this plugin and try to fix them?

And maybe this one is related too:

schungx · 29 Agosto, 2019 06:29

Anything uploaded with short-url automatically gets a 500.

Logs show this:

NoMethodError (undefined method `url_for' for #<FileStore::AzureStore:0x00007f4553fc2ae8>)
/var/www/discourse/app/controllers/uploads_controller.rb:107:in `show_short'

/var/www/discourse/app/controllers/uploads_controller.rb:107:in `show_short'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/base.rb:194:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/rendering.rb:30:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:132:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/callbacks.rb:41:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/rescue.rb:22:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-5.2.3/lib/active_record/railties/controller_runtime.rb:24:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/base.rb:134:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionview-5.2.3/lib/action_view/rendering.rb:32:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiling_methods.rb:78:in `block in profile_method'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal.rb:191:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal.rb:252:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:34:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:35:in `each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:35:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:840:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.5/lib/rack/protection/frame_options.rb:31:in `call'
/var/www/discourse/lib/middleware/omniauth_bypass_middleware.rb:68:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/tempfile_reaper.rb:15:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/conditional_get.rb:25:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/head.rb:12:in `call'
/var/www/discourse/lib/content_security_policy/middleware.rb:12:in `call'
/var/www/discourse/lib/middleware/anonymous_cache.rb:220:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:232:in `context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:226:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/cookies.rb:670:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:98:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/logster-2.3.2/lib/logster/middleware/reporter.rb:43:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/rack/logger.rb:38:in `call_app'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/rack/logger.rb:28:in `call'
/var/www/discourse/config/initializers/100-quiet_logger.rb:18:in `call'
/var/www/discourse/config/initializers/100-silence_logger.rb:31:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/request_id.rb:27:in `call'
/var/www/discourse/lib/middleware/enforce_hostname.rb:17:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/method_override.rb:22:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/executor.rb:14:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/sendfile.rb:111:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiler.rb:171:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/message_bus-2.2.2/lib/message_bus/rack/middleware.rb:57:in `call'
/var/www/discourse/lib/middleware/request_tracker.rb:169:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/engine.rb:524:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `public_send'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `method_missing'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:68:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:53:in `each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:53:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:605:in `process_client'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:700:in `worker_loop'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:548:in `spawn_missing_workers'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:144:in `start'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/bin/unicorn:128:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `load'
/var/www/discourse/vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `<main>'

I’m quite sure https://github.com/discourse/discourse-azure-blob-storage/blob/master/lib/azure_blob_store.rb is missing an implementation for url_for…

gerhard · 29 Agosto, 2019 06:58

We had a PR for that which unfortunately wasn’t merged, but there should be some great feedback in there in case anyone wants to start working on it.

github.com/discourse/discourse-azure-blob-storage

FIX: Implement url_for

master ← localjo:implement-url-for

closed 03:36PM - 08 Aug 19 UTC

localjo

+19 -0

This PR implements [the `url_for` function](https://github.com/discourse/discour…se/pull/7845) which Discourse uses to determine the URL of a download, taking into account the `force_download` parameter to [correctly set the `content-disposition` parameter for Azure](https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas#specifying-query-parameters-to-override-response-headers-blob-service-and-file-service-only). This fixes [the bug that was preventing users from downloading files stored in Azure](https://meta.discourse.org/t/user-archive-impossible-to-download-error-nomethoderror-filestore-azurestore/123687).

As I mentioned in FIX: Implement url_for by localjo · Pull Request #11 · discourse/discourse-azure-blob-storage · GitHub, as long as private uploads are not needed, the 3 new lines of the PR should actually be enough to fix the problem.

schungx · 29 Agosto, 2019 07:39

So… er… how should I pull this version with the PR instead?

Alternatively, how can I get the actual URL from the short-url? Is there a mapping table somewhere?

Because right now no attachment can be downloaded and it is frustrating…

schungx · 29 Agosto, 2019 08:51

OK, pulling from

git clone --single-branch --branch implement-url-for https://github.com/localjo/discourse-azure-blob-storage

works fine now. Will report after more testing.

schungx · 29 Agosto, 2019 09:30

This thing keeps coming up for the past few days, which I believe may be related to this issue:

/var/www/discourse/lib/file_store/base_store.rb:148:in `not_implemented'
/var/www/discourse/lib/file_store/base_store.rb:42:in `download_url'
/var/www/discourse/lib/cooked_post_processor.rb:386:in `add_lightbox!'
/var/www/discourse/lib/cooked_post_processor.rb:350:in `convert_to_link!'
/var/www/discourse/lib/cooked_post_processor.rb:682:in `block in post_process_images'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:238:in `block in each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:237:in `upto'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:237:in `each'
/var/www/discourse/lib/cooked_post_processor.rb:679:in `post_process_images'
/var/www/discourse/lib/cooked_post_processor.rb:42:in `block in post_process'
/var/www/discourse/lib/distributed_mutex.rb:31:in `block in synchronize'
/var/www/discourse/lib/distributed_mutex.rb:27:in `synchronize'
/var/www/discourse/lib/distributed_mutex.rb:27:in `synchronize'
/var/www/discourse/lib/distributed_mutex.rb:12:in `synchronize'
/var/www/discourse/lib/cooked_post_processor.rb:38:in `post_process'
/var/www/discourse/app/jobs/regular/process_post.rb:26:in `execute'
/var/www/discourse/app/jobs/base.rb:232:in `block (2 levels) in perform'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:63:in `with_connection'
/var/www/discourse/app/jobs/base.rb:221:in `block in perform'
/var/www/discourse/app/jobs/base.rb:217:in `each'
/var/www/discourse/app/jobs/base.rb:217:in `perform'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:192:in `execute_job'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:165:in `block (2 levels) in process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
/var/www/discourse/lib/sidekiq/pausable.rb:138:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in `invoke'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:164:in `block in process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:137:in `block (6 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:109:in `local'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:136:in `block (5 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq.rb:37:in `block in <module:Sidekiq>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:132:in `block (4 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:250:in `stats'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:127:in `block (3 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_logger.rb:8:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:126:in `block (2 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:74:in `global'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:125:in `block in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:48:in `with_context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:42:in `with_job_hash_context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:124:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:163:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:83:in `process_one'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:71:in `run'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:16:in `watchdog'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:25:in `block in safe_thread'

schungx · 29 Agosto, 2019 09:35

download_url must be another function not implemented by the Azure Blob plugin.

EDIT:

OK, the impacts of missing download_url are making themselves known.

The image post process job keeps failing
No images are optimized
No images are lightboxed
Topic List Preview can’t pick up the preview image

Can some kind soul (@gerhard?) please implement download_url?

EDIT 2:

@gerhard, can this be as simple as putting in:

def download_url(upload)
      return unless upload
      "#{upload.short_path}"
    end

If would love to clone the repo to test it out, but Discourse has become such a huge monster now that I am not sure if anything is going to break!

EDIT 3:

I’ve sent the following PR to localjo/discourse-azure-blob-storage:

https://github.com/localjo/discourse-azure-blob-storage/pull/1

It seems to resolve most of the visible problems without any visible adverse effects…

rainmanjam · 23 Diciembre, 2019 18:59

Is it possible to make some changes to allow Discourse to use Azure blob storage for backups?

NotAnonymous · 9 Enero, 2020 21:55

Estoy teniendo el mismo error. ¿Se integró tu PR? Si no es así, ¿puedes compartir los cambios realizados para ver si puedo implementarlos en nuestro sitio? No puedo acceder a la URL de GitHub que se muestra.

¡Gracias!

schungx · 31 Enero, 2020 09:41

Parece que el repositorio base ha desaparecido.

Puedes intentar clonar desde este:

git clone --single-branch --branch implement-url-for https://github.com/schungx/discourse-azure-blob-storage.git

Esto incluye mis cambios. Sin embargo, creo que algo más se rompió, lo cual aún no he corregido.

Una PR que envié al repositorio oficial:

schungx · 31 Enero, 2020 11:25

Parece que ha habido cambios masivos recientemente en el motor de almacenamiento S3 (del que azure-blob-storage roba características) para manejar cargas seguras.

En el proceso, ciertas funciones en la publicación de cocinas se rompen. Está generando HTML como este:

<img
    src="https://xxx.com/t/topic/3493"
    srcset=",  1.5x,  2x"
    style="position: absolute; top: 0px; left: 0px; width: 678px; height: 388px;" 
    class="d-lazyload d-lazyload-hidden"
>

Nótese que:

El src está configurado como el enlace del tema en lugar de la URL de la imagen.
Las URL del srcset desaparecen todas (probablemente devolviendo valores vacíos).
Ninguna de las imágenes optimizadas se genera realmente (probablemente debido a que las URL están vacías).

Este es un HTML que funciona correctamente:

<img
    src="https://xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_375x500.jpeg" 
    alt="20200113_163717" data-base62-sha1="51nILqcSQo5kGA4iz67LGoQmSpm"
    class="d-lazyload"
    srcset="//xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_375x500.jpeg, //xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_562x750.jpeg 1.5x, //xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_750x1000.jpeg 2x" 
    width="375" height="500"
>

Para esta imagen, todo funcionó correctamente.

El código para generar las imágenes optimizadas se encuentra en UrlHelper.cook_url, el cual experimentó cambios importantes para manejar cargas seguras a S3.

NotAnonymous · 31 Enero, 2020 14:40

Gracias por la información; al final lo solucioné basándome en tus comentarios.

Sobre los cambios recientes, yo también lo descubrí. Fue una solución sencilla: solo hay que añadir el parámetro seguro (el cuarto) a la función optimize en el plugin. No estoy seguro de si se necesitan otros cambios, pero esto resolvió el problema inmediato que señalaste.

schungx · 31 Enero, 2020 14:43

Desde que se actualizó hace unos cuatro días, todos los optimized_images tienen el campo url establecido en null en lugar de la URL correcta de la imagen.

Esto hace que Discourse falle de manera terrible, porque upload.thumbnail devuelve un registro válido, pero la url es null. ¿No debería haber alguna protección en algún lugar para verificar esto?

Lo que significa que esta línea:

github.com/discourse/discourse

lib/cooked_post_processor.rb

d07f03946


      
              .sort
              .each { |r| yield r if r > 1 }
          end
          
          def optimize_image!(img, upload, cropped: false)
            w, h = img["width"].to_i, img["height"].to_i
          
            # note: optimize_urls cooks the src and data-small-upload further after this
            thumbnail = upload.thumbnail(w, h)
            if thumbnail && thumbnail.filesize.to_i < upload.filesize
              img["src"] = thumbnail.url
          
              srcset = +""
          
              each_responsive_ratio do |ratio|
                resized_w = (w * ratio).to_i
                resized_h = (h * ratio).to_i
          
                if !cropped && upload.width && resized_w > upload.width
                  cooked_url = UrlHelper.cook_url(upload.url, secure: @post.with_secure_media?)
                  srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"

establece img["src"] en null. Estoy seguro de que eso no alegrará a nadie.

Todas las imágenes en srcset se establecen como vacías porque:

github.com/discourse/discourse

lib/cooked_post_processor.rb

d07f03946


      
          
            srcset = +""
          
            each_responsive_ratio do |ratio|
              resized_w = (w * ratio).to_i
              resized_h = (h * ratio).to_i
          
              if !cropped && upload.width && resized_w > upload.width
                cooked_url = UrlHelper.cook_url(upload.url, secure: @post.with_secure_media?)
                srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"
              elsif t = upload.thumbnail(resized_w, resized_h)
                cooked_url = UrlHelper.cook_url(t.url, secure: @post.with_secure_media?)
                srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"
              end
          
              img["srcset"] = "#{UrlHelper.cook_url(img["src"], secure: @post.with_secure_media?)}#{srcset}" if srcset.present?
            end
          else
            img["src"] = upload.url
          end

t.url termina siendo null.

Luego, todo termina exactamente como está. Estoy bastante seguro de que, en algún punto de la cadena, si img["src"] es null, se establece en la URL del tema en sí.

Por lo tanto, el culpable es el hecho de que las imágenes optimizadas NO se están creando (pero los registros sí, con url en null). No hay mensajes de error.

Cualquier publicación con imágenes que tengan imágenes optimizadas válidas (con url válida) sigue funcionando perfectamente, incluso al reconstruir el HTML.

Cualquier imagen que haya sido subida anteriormente (con imágenes optimizadas válidas), al volver a subirla, sigue funcionando perfectamente.

schungx · 31 Enero, 2020 14:45

EDITA: OK, agregué secure: false a store_optimized_image y todo parece funcionar bien ahora.

schungx · 31 Enero, 2020 16:34

Sigo creyendo que se debe hacer algo para manejar situaciones donde OptimizedImage tiene url = "" (no null).

Esto AÚN ocurrirá, pero parece que solo para algunas imágenes y no para otras. Para ciertas imágenes de ese tipo, las versiones pequeñas creadas al usar el plugin Topics List Preview fallarán al generarse y, por lo tanto, dejarán registros con url="".

Por lo general, estas no se mostrarán porque las imágenes responsivas comienzan desde 1x del tamaño mínimo y aumentan (de forma predeterminada) hasta 2x. Por lo tanto, nunca se accede a las imágenes optimizadas pequeñas. Sin embargo, sigue siendo una preocupación que algún día cause problemas…

Esto no significa que no se mostrará una imagen de vista previa en la lista de temas cuando el plugin Topics List Preview esté instalado.

schungx · 22 Mayo, 2020 05:50

Se produjo un error al actualizar Discourse debido a un conflicto con faraday:


I, [2020-05-22T05:46:54.081847 #1]  INFO -- : > cd /var/www/discourse && su discourse -c 'bundle exec rake db:migrate'
rake aborted!
Gem::ConflictError: Unable to activate faraday_middleware-0.11.0, because faraday-1.0.1 conflicts with faraday (>= 0.7.4, < 1.0)
/var/www/discourse/lib/plugin_gem.rb:20:in `load'
/var/www/discourse/lib/plugin/instance.rb:635:in `gem'
/var/www/discourse/plugins/discourse-azure-blob-storage/plugin.rb:10:in `activate!'
/var/www/discourse/lib/plugin/instance.rb:541:in `instance_eval'
/var/www/discourse/lib/plugin/instance.rb:541:in `activate!'
lib/discourse.rb:224:in `block in activate_plugins!'
lib/discourse.rb:221:in `each'
lib/discourse.rb:221:in `activate_plugins!'
/var/www/discourse/config/application.rb:297:in `block in <class:Application>'
/var/www/discourse/lib/plugin_initialization_guard.rb:5:in `plugin_initialization_guard'
/var/www/discourse/config/application.rb:296:in `<class:Application>'
/var/www/discourse/config/application.rb:65:in `<module:Discourse>'
/var/www/discourse/config/application.rb:64:in `<top (required)>'
/var/www/discourse/Rakefile:7:in `require'
/var/www/discourse/Rakefile:7:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'

¿Usa discourse-azure-blob-storage faraday?

itsbhanusharma · 22 Mayo, 2020 05:57

Sí, así es

github.com/discourse/discourse-azure-blob-storage

plugin.rb

67d13a285


      
          # name: discourse-azure-blob-storage
          # about: Azure Blob storage
          # version: 0.0.2
          # authors: Maja Komel
          # url: https://github.com/discourse/discourse-azure-blob-storage
          
          require "file_store/base_store"
          
          # GEMS
          gem 'faraday_middleware', '0.11.0', {require: false}
          gem 'azure-core', '0.1.13', {require: false}
          gem 'azure-storage-common', '1.0.1', {require: false}
          gem 'azure-storage-blob', '1.0.1', {require: false}
          
          require 'azure/storage/blob'
          
          enabled_site_setting :azure_blob_storage_enabled
          
          after_initialize do

schungx · 22 Mayo, 2020 06:38

Genial.

Esto lo soluciona.

meglio · 8 Agosto, 2020 14:08

¿Este plugin sigue fallando?

¿Alguien está usando actualmente este plugin para subir archivos a Azure Blob Storage? De ser así, ¿es estable? Por favor, comparte tu experiencia.

Tema		Respuestas	Vistas
Plugin to store uploads into Azure blob storage Feature	14	2020	23 Febrero 2018
Wrong images link after cooking - since recent upgrade Support	5	1049	2 Febrero 2020
[Not implemented] Error after upload any new image with azure blob storage Bug	5	1015	4 Agosto 2021
All image uploads to Azure return Internal Server Error Support	6	1011	24 Agosto 2023
Need Azure blob storage Feature	2	1245	31 Agosto 2021

Plugin de Azure Blob Storage

Temas relacionados