Plugin Azure Blob Storage

sam · Mars 7, 2019, 9:00

Awesome, @vinothkannans can you review and merge ?

AJRT · Juillet 23, 2019, 3:33

Hello @maja

I have some issue, which could be related with this plugin.
There is more info about this issue:

Could you check if the problem is with this plugin and try to fix them?

And maybe this one is related too:

schungx · Août 29, 2019, 6:29

Anything uploaded with short-url automatically gets a 500.

Logs show this:

NoMethodError (undefined method `url_for' for #<FileStore::AzureStore:0x00007f4553fc2ae8>)
/var/www/discourse/app/controllers/uploads_controller.rb:107:in `show_short'

/var/www/discourse/app/controllers/uploads_controller.rb:107:in `show_short'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/base.rb:194:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/rendering.rb:30:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:132:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/callbacks.rb:41:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/rescue.rb:22:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activerecord-5.2.3/lib/active_record/railties/controller_runtime.rb:24:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/abstract_controller/base.rb:134:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionview-5.2.3/lib/action_view/rendering.rb:32:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiling_methods.rb:78:in `block in profile_method'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal.rb:191:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_controller/metal.rb:252:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:34:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:35:in `each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/journey/router.rb:35:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/routing/route_set.rb:840:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.5/lib/rack/protection/frame_options.rb:31:in `call'
/var/www/discourse/lib/middleware/omniauth_bypass_middleware.rb:68:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/tempfile_reaper.rb:15:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/conditional_get.rb:25:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/head.rb:12:in `call'
/var/www/discourse/lib/content_security_policy/middleware.rb:12:in `call'
/var/www/discourse/lib/middleware/anonymous_cache.rb:220:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:232:in `context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:226:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/cookies.rb:670:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:98:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/logster-2.3.2/lib/logster/middleware/reporter.rb:43:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/rack/logger.rb:38:in `call_app'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/rack/logger.rb:28:in `call'
/var/www/discourse/config/initializers/100-quiet_logger.rb:18:in `call'
/var/www/discourse/config/initializers/100-silence_logger.rb:31:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/request_id.rb:27:in `call'
/var/www/discourse/lib/middleware/enforce_hostname.rb:17:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/method_override.rb:22:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/executor.rb:14:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/sendfile.rb:111:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiler.rb:171:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/message_bus-2.2.2/lib/message_bus/rack/middleware.rb:57:in `call'
/var/www/discourse/lib/middleware/request_tracker.rb:169:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/engine.rb:524:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `public_send'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `method_missing'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:68:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:53:in `each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-2.0.7/lib/rack/urlmap.rb:53:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:605:in `process_client'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:700:in `worker_loop'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:548:in `spawn_missing_workers'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/lib/unicorn/http_server.rb:144:in `start'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/unicorn-5.5.1/bin/unicorn:128:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `load'
/var/www/discourse/vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `<main>'

I’m quite sure https://github.com/discourse/discourse-azure-blob-storage/blob/master/lib/azure_blob_store.rb is missing an implementation for url_for…

gerhard · Août 29, 2019, 6:58

We had a PR for that which unfortunately wasn’t merged, but there should be some great feedback in there in case anyone wants to start working on it.

github.com/discourse/discourse-azure-blob-storage

FIX: Implement url_for

master ← localjo:implement-url-for

closed 03:36PM - 08 Aug 19 UTC

localjo

+19 -0

This PR implements [the `url_for` function](https://github.com/discourse/discour…se/pull/7845) which Discourse uses to determine the URL of a download, taking into account the `force_download` parameter to [correctly set the `content-disposition` parameter for Azure](https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas#specifying-query-parameters-to-override-response-headers-blob-service-and-file-service-only). This fixes [the bug that was preventing users from downloading files stored in Azure](https://meta.discourse.org/t/user-archive-impossible-to-download-error-nomethoderror-filestore-azurestore/123687).

As I mentioned in FIX: Implement url_for by localjo · Pull Request #11 · discourse/discourse-azure-blob-storage · GitHub, as long as private uploads are not needed, the 3 new lines of the PR should actually be enough to fix the problem.

schungx · Août 29, 2019, 7:39

So… er… how should I pull this version with the PR instead?

Alternatively, how can I get the actual URL from the short-url? Is there a mapping table somewhere?

Because right now no attachment can be downloaded and it is frustrating…

schungx · Août 29, 2019, 8:51

OK, pulling from

git clone --single-branch --branch implement-url-for https://github.com/localjo/discourse-azure-blob-storage

works fine now. Will report after more testing.

schungx · Août 29, 2019, 9:30

This thing keeps coming up for the past few days, which I believe may be related to this issue:

/var/www/discourse/lib/file_store/base_store.rb:148:in `not_implemented'
/var/www/discourse/lib/file_store/base_store.rb:42:in `download_url'
/var/www/discourse/lib/cooked_post_processor.rb:386:in `add_lightbox!'
/var/www/discourse/lib/cooked_post_processor.rb:350:in `convert_to_link!'
/var/www/discourse/lib/cooked_post_processor.rb:682:in `block in post_process_images'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:238:in `block in each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:237:in `upto'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/nokogiri-1.10.4/lib/nokogiri/xml/node_set.rb:237:in `each'
/var/www/discourse/lib/cooked_post_processor.rb:679:in `post_process_images'
/var/www/discourse/lib/cooked_post_processor.rb:42:in `block in post_process'
/var/www/discourse/lib/distributed_mutex.rb:31:in `block in synchronize'
/var/www/discourse/lib/distributed_mutex.rb:27:in `synchronize'
/var/www/discourse/lib/distributed_mutex.rb:27:in `synchronize'
/var/www/discourse/lib/distributed_mutex.rb:12:in `synchronize'
/var/www/discourse/lib/cooked_post_processor.rb:38:in `post_process'
/var/www/discourse/app/jobs/regular/process_post.rb:26:in `execute'
/var/www/discourse/app/jobs/base.rb:232:in `block (2 levels) in perform'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:63:in `with_connection'
/var/www/discourse/app/jobs/base.rb:221:in `block in perform'
/var/www/discourse/app/jobs/base.rb:217:in `each'
/var/www/discourse/app/jobs/base.rb:217:in `perform'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:192:in `execute_job'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:165:in `block (2 levels) in process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
/var/www/discourse/lib/sidekiq/pausable.rb:138:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in `invoke'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:164:in `block in process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:137:in `block (6 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:109:in `local'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:136:in `block (5 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq.rb:37:in `block in <module:Sidekiq>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:132:in `block (4 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:250:in `stats'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:127:in `block (3 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_logger.rb:8:in `call'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:126:in `block (2 levels) in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:74:in `global'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:125:in `block in dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:48:in `with_context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:42:in `with_job_hash_context'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:124:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:163:in `process'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:83:in `process_one'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:71:in `run'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:16:in `watchdog'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:25:in `block in safe_thread'

schungx · Août 29, 2019, 9:35

download_url must be another function not implemented by the Azure Blob plugin.

EDIT:

OK, the impacts of missing download_url are making themselves known.

The image post process job keeps failing
No images are optimized
No images are lightboxed
Topic List Preview can’t pick up the preview image

Can some kind soul (@gerhard?) please implement download_url?

EDIT 2:

@gerhard, can this be as simple as putting in:

def download_url(upload)
      return unless upload
      "#{upload.short_path}"
    end

If would love to clone the repo to test it out, but Discourse has become such a huge monster now that I am not sure if anything is going to break!

EDIT 3:

I’ve sent the following PR to localjo/discourse-azure-blob-storage:

https://github.com/localjo/discourse-azure-blob-storage/pull/1

It seems to resolve most of the visible problems without any visible adverse effects…

rainmanjam · Décembre 23, 2019, 6:59

Is it possible to make some changes to allow Discourse to use Azure blob storage for backups?

NotAnonymous · Janvier 9, 2020, 9:55

I’m running into this same error. Was your PR incorporated? If not, can you share the changes made so I can see if I can implement on our site? I can’t access the github url shown.

Thanks!

schungx · Janvier 31, 2020, 9:41

Le dépôt de base semble avoir disparu.

Vous pouvez essayer de cloner depuis celui-ci :

git clone --single-branch --branch implement-url-for https://github.com/schungx/discourse-azure-blob-storage.git

Celui-ci contient mes modifications. Cependant, je pense qu’autre chose s’est cassé, ce que je n’ai pas encore réparé.

Une PR que j’ai faite sur le dépôt officiel :

schungx · Janvier 31, 2020, 11:25

Il semble y avoir d’importants changements récents dans le moteur de stockage S3 (dont azure-blob-storage s’inspire) pour gérer les téléversements sécurisés.

En cours de route, certaines opérations sur les posts de cuisine sont rompues. Cela génère un HTML comme ceci :

<img
    src="https://xxx.com/t/topic/3493"
    srcset=",  1.5x,  2x"
    style="position: absolute; top: 0px; left: 0px; width: 678px; height: 388px;" 
    class="d-lazyload d-lazyload-hidden"
>

Remarquez que :

Le src est défini sur le lien du sujet au lieu de l’URL de l’image.
Les URL de srcset disparaissent toutes (renvoyant probablement des valeurs vides).
Aucune des images optimisées n’est réellement générée (probablement en raison des URL vides).

Voici un exemple de HTML qui fonctionne correctement :

<img
    src="https://xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_375x500.jpeg" 
    alt="20200113_163717" data-base62-sha1="51nILqcSQo5kGA4iz67LGoQmSpm"
    class="d-lazyload"
    srcset="//xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_375x500.jpeg, //xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_562x750.jpeg 1.5x, //xxx.blob.core.windows.net/support/optimized/2X/2/2332e15b99ee86620e2f890d38aaceb16954cc8c_2_750x1000.jpeg 2x" 
    width="375" height="500"
>

Pour cette image, tout fonctionnait correctement.

Le code générant les images optimisées se trouvait dans UrlHelper.cook_url, qui a subi des modifications importantes pour gérer les téléversements sécurisés vers S3.

NotAnonymous · Janvier 31, 2020, 2:40

Merci pour l’info, j’ai fini par régler le problème grâce à vos commentaires.

Pour les modifications récentes, je l’ai découvert moi aussi. C’était une correction simple : il suffit d’ajouter le paramètre sécurisé (4e) à la fonction optimize dans le plugin. Je ne sais pas si d’autres modifications sont nécessaires, mais cela a résolu le problème immédiat que vous avez signalé.

schungx · Janvier 31, 2020, 2:43

Depuis la mise à niveau d’il y a environ quatre jours, tous les optimized_images ont le champ url défini sur null au lieu de l’URL correcte de l’image.

Cela provoque des dysfonctionnements graves de Discourse, car upload.thumbnail renvoie un enregistrement valide, mais le url est nul. Ne devrait-il pas y avoir une vérification quelque part pour éviter cela ?

Cela signifie que cette ligne :

github.com/discourse/discourse

lib/cooked_post_processor.rb

d07f03946


      
              .sort
              .each { |r| yield r if r > 1 }
          end
          
          def optimize_image!(img, upload, cropped: false)
            w, h = img["width"].to_i, img["height"].to_i
          
            # note: optimize_urls cooks the src and data-small-upload further after this
            thumbnail = upload.thumbnail(w, h)
            if thumbnail && thumbnail.filesize.to_i < upload.filesize
              img["src"] = thumbnail.url
          
              srcset = +""
          
              each_responsive_ratio do |ratio|
                resized_w = (w * ratio).to_i
                resized_h = (h * ratio).to_i
          
                if !cropped && upload.width && resized_w > upload.width
                  cooked_url = UrlHelper.cook_url(upload.url, secure: @post.with_secure_media?)
                  srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"

affecte img["src"] à null. Je suis certain que cela ne va pas arranger les choses.

Toutes les images dans srcset sont définies sur vide car :

github.com/discourse/discourse

lib/cooked_post_processor.rb

d07f03946


      
          
            srcset = +""
          
            each_responsive_ratio do |ratio|
              resized_w = (w * ratio).to_i
              resized_h = (h * ratio).to_i
          
              if !cropped && upload.width && resized_w > upload.width
                cooked_url = UrlHelper.cook_url(upload.url, secure: @post.with_secure_media?)
                srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"
              elsif t = upload.thumbnail(resized_w, resized_h)
                cooked_url = UrlHelper.cook_url(t.url, secure: @post.with_secure_media?)
                srcset << ", #{cooked_url} #{ratio.to_s.sub(/\.0$/, "")}x"
              end
          
              img["srcset"] = "#{UrlHelper.cook_url(img["src"], secure: @post.with_secure_media?)}#{srcset}" if srcset.present?
            end
          else
            img["src"] = upload.url
          end

t.url se retrouve être null.

Ensuite, tout se termine exactement comme c’est le cas. Je suis tout à fait certain que, quelque part plus loin dans le processus, si img["src"] est null, il est alors défini sur l’URL du sujet lui-même.

Par conséquent, le coupable est le fait que les images optimisées ne sont PAS créées (mais les enregistrements le sont, avec un url nul). Il n’y a aucun message d’erreur.

Tout message contenant des images avec des versions optimisées valides (avec un url valide) continue de fonctionner parfaitement, même lors de la reconstruction du HTML.

Toute image ayant été téléchargée précédemment (avec des versions optimisées valides), lorsqu’elle est téléchargée à nouveau, continue de fonctionner parfaitement.

schungx · Janvier 31, 2020, 2:45

EDIT : OK, j’ai ajouté secure: false à store_optimized_image et tout semble fonctionner correctement maintenant.

schungx · Janvier 31, 2020, 4:34

Je suis toujours convaincu qu’il faut agir pour gérer les cas où OptimizedImage a url = "" (et non null).

Cela SE PRODUIRA TOUJOURS, mais semble ne concerner que certaines images et pas d’autres. Pour certaines images de ce type, les versions réduites créées lors de l’utilisation du plugin Topics List Preview échouent à être générées, laissant ainsi des enregistrements avec url="".

Ces cas ne se manifestent généralement pas, car les images responsives ne commencent qu’à partir de 1x de la taille minimale et augmentent (par défaut) jusqu’à 2x. Par conséquent, les petites images optimisées ne sont jamais sollicitées. Cependant, cela reste une préoccupation : un jour, cela pourrait causer un problème…

Cela ne signifie pas qu’une image de prévisualisation n’apparaîtra pas dans la liste des sujets lorsque le plugin Topics List Preview est installé.

schungx · Mai 22, 2020, 5:50

Une erreur est survenue lors de la mise à niveau de Discourse en raison d’un conflit avec faraday :


I, [2020-05-22T05:46:54.081847 #1]  INFO -- : > cd /var/www/discourse && su discourse -c 'bundle exec rake db:migrate'
rake aborted!
Gem::ConflictError: Impossible d'activer faraday_middleware-0.11.0, car faraday-1.0.1 est en conflit avec faraday (>= 0.7.4, < 1.0)
/var/www/discourse/lib/plugin_gem.rb:20:in `load'
/var/www/discourse/lib/plugin/instance.rb:635:in `gem'
/var/www/discourse/plugins/discourse-azure-blob-storage/plugin.rb:10:in `activate!'
/var/www/discourse/lib/plugin/instance.rb:541:in `instance_eval'
/var/www/discourse/lib/plugin/instance.rb:541:in `activate!'
lib/discourse.rb:224:in `block in activate_plugins!'
lib/discourse.rb:221:in `each'
lib/discourse.rb:221:in `activate_plugins!'
/var/www/discourse/config/application.rb:297:in `block in <class:Application>'
/var/www/discourse/lib/plugin_initialization_guard.rb:5:in `plugin_initialization_guard'
/var/www/discourse/config/application.rb:296:in `<class:Application>'
/var/www/discourse/config/application.rb:65:in `<module:Discourse>'
/var/www/discourse/config/application.rb:64:in `<top (required)>'
/var/www/discourse/Rakefile:7:in `require'
/var/www/discourse/Rakefile:7:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'

Est-ce que discourse-azure-blob-storage utilise faraday ?

itsbhanusharma · Mai 22, 2020, 5:57

Oui, c’est bien le cas

github.com/discourse/discourse-azure-blob-storage

plugin.rb

67d13a285


      
          # name: discourse-azure-blob-storage
          # about: Azure Blob storage
          # version: 0.0.2
          # authors: Maja Komel
          # url: https://github.com/discourse/discourse-azure-blob-storage
          
          require "file_store/base_store"
          
          # GEMS
          gem 'faraday_middleware', '0.11.0', {require: false}
          gem 'azure-core', '0.1.13', {require: false}
          gem 'azure-storage-common', '1.0.1', {require: false}
          gem 'azure-storage-blob', '1.0.1', {require: false}
          
          require 'azure/storage/blob'
          
          enabled_site_setting :azure_blob_storage_enabled
          
          after_initialize do

schungx · Mai 22, 2020, 6:38

Parfait.

Cela corrige le problème.

meglio · Août 8, 2020, 2:08

Ce plugin est-il toujours cassé ?

Quelqu’un utilise-t-il actuellement ce plugin pour des uploads vers Azure Blob Storage ? Si oui, est-il stable ? Merci de partager votre expérience.

Sujet		Réponses	Vues
Plugin to store uploads into Azure blob storage Feature	14	2020	Février 23, 2018
Wrong images link after cooking - since recent upgrade Support	5	1049	Février 2, 2020
[Not implemented] Error after upload any new image with azure blob storage Bug	5	1015	Août 4, 2021
All image uploads to Azure return Internal Server Error Support	6	1011	Août 24, 2023
Need Azure blob storage Feature	2	1245	Août 31, 2021

Plugin Azure Blob Storage

Sujets connexes