Behaviour of external links for not logged-in visitors

Contribute Feature

AI-generated summary

The discussion revolves around the behavior of external links for non-logged-in visitors in Discourse, specifically regarding the default_external_links_in_new_tab setting. arajvanshi notes that while the setting works for new users, it doesn’t affect non-logged-in visitors. mcwumbly explains that the setting was recently added and may not have been designed to affect anonymous users, as it only applies to current users. riking shares a PR to address this, acknowledging the behavior may have been intentional. Barnabas20 confirms non-logged-in users still can’t open external links in new tabs. sam asks about the status, and MarcP supports the idea, suggesting it’s useful for guests to open external links in new tabs. The issue is tagged as pr-welcome, indicating it’s open for contributions.

1

I selected the setting default_external_links_in_new_tab in the admin area. This resulted in the expected behaviour of setting default preference of all new users set to ‘open external links in new tab’.

However, for non-logged-in visitors, the behaviour is still the old one, it is opening the external links in the same tab leading visitors to go away from the website. When admin selects the default_external_links_in_new_tab setting, it should change the behaviour for non-logged-in visitors as well.

4 إعجابات
2

Any update on this issue? Anything I can do to fix this locally?

3

The default_external_links_in_new_tab setting was added relatively recently. Before that, only end users could change this via their user preferences.

I am guessing the issue is that when that setting was added, it was implemented such that when a new user is created, their initial preference is set.

But the logic still holds that the setting is only effective for the current user via their preferences.

This may or may not have been a conscious decision, so I think you should recategorize this topic as a “feature” request.

إعجاب واحد (1)
4

I knocked together a quick PR:

https://github.com/discourse/discourse/pull/2278

The ‘false’ behavior was from acting on an undefined value returned from Discourse.User.currentProp() when there is no current user, so it seemed to me to not be intentional one way or the other.

4 إعجابات
5

Non logged in users still not able open external links on new tab.

6

Is there any update plan on that?

7

Is this feature available yet?

8

@riking what is going on here?

9

We still have the problem behavior mentioned in the OP.

11

pr-welcome here, I do not think this is bug proper, rather expanded functionality for anon.

3 إعجابات
12

أعتقد أن فتح الروابط الخارجية في تبويبات جديدة سيكون مفيدًا للمستخدمين المجهولين/الزوار.. قد نفقد حركة المرور هنا لأنهم يغادرون الموقع بعد النقر على رابط في موضوع ما.