L'icône de l'horloge dans les favoris est cassée après avoir changé le jeu d'icônes

When changing the FontAwesome Pro icons from Solid to Light, the icon that shows when you set a bookmark with a reminder time on a post no longer shows up.

It looks like the plugin changes <use xlink:href="#discourse-bookmark-clock"></use> to <use xlink:href="#fal-discourse-bookmark-clock"></use>, but this just appears blank because there is no fal version of this icon.

3 « J'aime »

I have the exact same issue, on 2.9beta9 tests-passed

1 « J'aime »

Digging out this one as it’s still an issue on 3.2

1 « J'aime »

We still have this issue on 3.3 :smiley:

1 « J'aime »

I’ve just made an update to the plugin that will use our default bookmark clock icon so it will no longer appear blank.

Unfortunately since this is a custom icon we built for Discourse based on the open source set of fontawesome icons, I don’t think we can actually build and distribute a version of this icon that uses the pro style as it would violate the fontawesome pro licensing.

2 « J'aime »

This topic was automatically closed 6 days after the last reply. New replies are no longer allowed.

I see the icon has been re-added in eb39fb6 but even when I checkout your fix and not any newer commits on 3.3.1 stable, it brings back the bookmark clock icon but unfortunately it makes the more button (d-icon-ellipsis-h) and edit button (d-icon-pencil-alt) disappear… do you have any idea what is going on? I tried clearing the icon cache but to no avail.

04580bafdc99c6f1cdf32ee06091e81c34aeddc6

3 « J'aime »

i wonder if related - Some icons not showing up after upgrade :thinking:

1 « J'aime »

I think according to .discourse-compatibility you’re pinned to an older version of the plugin, right? maybe a compatibility issue with older versions of Discourse? discourse-fontawesome-pro/.discourse-compatibility at eb39fb6bdc567b77a54ce50366b804c9971467e2 · discourse/discourse-fontawesome-pro · GitHub

I wouldn’t expect removing a reference to a single icon to break unrelated icons :thinking:

1 « J'aime »

Good catch, but no, I ignored that :sunglasses:

2 « J'aime »

hmm and you don’t have the later commit that renamed the icons? DEV: update plugin to be compatible with core upgrade to fontawesome … · discourse/discourse-fontawesome-pro@eb39fb6 · GitHub

When you dig into the inspector, is the reference for the icon ellipsis or ellipsis-h?

image

3 « J'aime »

So I am on cc8e59d7

image

1 « J'aime »

Im unclear if we need to keep this open @RGJ ?

Well… it’s still an unresolved issue… I have no idea what is causing this.

So it would be good if anyone who had something useful to add would be able to add it :wink:

1 « J'aime »