Broken image on local onebox content

onebox

(Daniel Hollands) #1

I’ve noticed this as an issue for a while now, but have mostly ignored it until now.

When using onebox to display local content (such as another post within the forum), there is a broken image shown next to the title:

I think I can even demonstrate this here:

The html for the image is:

<img src="" class="thumbnail" height="" width="">

Any ideas?


(Jeff Atwood) #2

@techapj can you have a look?


(Arpit Jalan) #3

I am not able to repro this issue on try or here on meta.


(Daniel Hollands) #4

Can you not see the issue in the post above? I’m literally seeing the broken image right now here on meta.


(Mittineague) #5

That’s from an external site,

But this does work here (internal)

External (SitePoint)


(Daniel Hollands) #6

That external link has a broken image.


(Arpit Jalan) #7

Okay, I can repro this on latest Firefox. Looking into it now.


(Arpit Jalan) #8

Fixed :ant:

https://github.com/discourse/onebox/commit/765434fe94b08c3e1d5d021f23c99d5cdca2bc98


(Jeff Atwood) #9