Browser upgrade fails when discourse is configured to use one unicorn worker

[RBoy]

Linked to the posts here where it was suggested this may be a bug.

Builds taking very long time

This seems like a bug, especially as the system cuts down to a single unicorn temporarily very shortly afterwards. The number 2 is hardcoded, as is the number 1 for the reduction. Edit: looks like this change introduced the inconsistency I think your post (and this reply) should be a in a new thread, in the bugs category.

Builds taking very long time

I’m also going to add more to this, I’m running a lean system (1GB ram) and a small site. It has 2 unicorn workers and between them each was taking up 30% of the memory which was causing a lot of memory thrashing, so I decided to cut down the number from 2 to 1 (which I believe can handle about 10 concurrent connections each). This made a HUGE difference and made the page loads almost instantaneous and reduced swapping by a factor of 5-10 (depending on what was being loaded). The downside that …

[Ed_S]

Let me redo my response here:

@RBoy

ABORTING, you do not have enough unicorn workers running

This seems like a bug, especially as the system cuts down to a single unicorn temporarily very shortly afterwards.

The number 2 is hardcoded, as is the number 1 for the reduction.

discourse/docker_manager/blob/main/lib/docker_manager/upgrader.rb#L37C1-L41C1

Edit: looks like this change introduced the inconsistency

FEATURE: Cycle Unicorn and reduce unicorn workers in upgrade process.

Thanks for the new thread.

[sam (Sam Saffron)]

Yeah I just don’t think we can support this, the bug fix here will be simply to make it impossible to happen, not fix the upgrade code.

[Ed_S]

@sam

make it impossible to happen

Make what impossible? Setting a single unicorn? And yet such a setup worked better for the OP, until the upgrade.

And because the upgrade drops the number of unicorns to 1, it seems clear to me that 1 unicorn is enough at the time of an upgrade.

Have you looked at the history of this bit of code?

[sam (Sam Saffron)]

No just make it impossible to upgrade via the ui if you only have 1 unicorn

Force you to rebuild from console, memory is too constrained anyway

[Ed_S]

Fair enough - I’ve resorted to always using the console these days, on my memory-limited instances.