Bug in inviting users (?) Cannot login, claiming activation already sent (false)


(Nordize) #1

Just installed from docker the latest 1.8.0.beta7. I think I stumbled upon a bug. Here’s what I did:

  1. checked login required in Settings (it’s a closed discussion forum)
  2. sent invite to a user
  • user got the invite and clicks the link
  • user got to the page asking for their username and optional password
  • user fills in both fields and clicks “accept invitation”
  • the interface logs them in automatically (no further emails are sent)
  • user logs out
  • user tries to log back in, but now interface says:
    You can't log in yet. We previously sent an activation email to you at user@domain.com. Please follow the instructions in that email to activate your account. Click here to send the activation email again.
  • this is false, an activation email was not sent
  1. user clicks on “here” to resend activation email
  • interface then says:
    Sorry, this account has already been activated.
  • which is true, but it is not approved, here’s what the Admin > Users panel shows for their account:
    https://gyazo.com/e26ab0f2e831fed71834d9a70c731ddc
  • user is stuck and can no longer login

However!

If the user does not fill in the password at step 5. above, then an activation email is actually sent, and the user can properly activate the account and login. But this is cumbersome and impractical as I would need to warn all users in advance…

This must be a bug, right?

I tried quite a few combinations in Settings. This happens whether or not invite only is checked. Here are the relevant Login settings:

https://gyazo.com/3b82259df2f089ea6db001185e868dbf


Buggy activation email false alarm?
Invited users ending up with unactivated account
(Arpit Jalan) #4

This is now fixed via:

Invited user will now receive a “Confirm your account” email if they set password while accepting the invite. This is done to validate their email address (in case the invite link was copied and handed over directly).

This is a separate issue and I just opened a PR that fixes it:

Thanks for detailed repro steps @nordize :thumbsup:


(Arpit Jalan) #5