Canned Replies CSS (desktop) Highlighting Issue

bug
1

Hi,

I’ve noticed an issue we have on the use of canned replies. When you place the mouse over the individual canned reply, it is highlighted, unfortunately, this appears to be using the same colour as that of the characters, making it unreadable.

I’ve been poking around with Chrome’s Inspect feature and I believe the CSS class in question is : canned-reply-title

What I am uncertain of is how I can see what is within this specific class, as it doesn’t appear to be displayed in the Inspect feature, but if you remove it, the highlighting no longer occurs.

Any help would be appreciated.

Examples:

image
image.png707×176 3.56 KB

image

image

2 Likes
4

Hi Rob, thanks for reporting!

This is fixed via:

https://github.com/discourse/discourse-canned-replies/commit/03dc6eb146f289a11feea4018ea5d079c2e3917f

Canned replies will now use the normal highlight color. It would look like this on the dark theme:

Capture
Capture848×644 14.1 KB

And like this on the light theme:

Capture
Capture800×529 18.8 KB

The reason you don’t see the styles is because you need the element to be hovered for them to show in devtools.

You can simulate hovering the element by right clicking on it in the tree and go to force state then hover.

Like so:

Untitled
Untitled1229×798 69.4 KB

You will then see the hover styles applied to the element, like so:

Capture

7 Likes
6

Hi Joe,

Thank you so much for such a prompt response, fix and explanation! :slight_smile:

I did try clicking on an option near the top of the dev tools which suggested it would force a hover action, but it didn’t seem to do anything, so the thing regarding the right-click is really useful also.

Many thanks :slight_smile:

Last question, any rough idea on when this may be applied to our hosted solution? (community.gamedev.tv).

Thanks in advance,

Rob

2 Likes
7

You’re most welcome Rob.

It should be in within the next few hours.

However, I’ve also manually added it to your theme until the fix is deployed on your site. So you should be good to go now.

3 Likes
8

That’s awesome, thanks Joe, really appreciated :slight_smile:

Looks fab by the way, just had a play! :slight_smile:

1 Like
9

Can you eliminate the HR line between canned replies while we are at it? They seem unnecessary to me.

3 Likes
10

Yes!

Done via:

https://github.com/discourse/discourse-canned-replies/commit/4f94b85f30e539c39abe51c6fd45917d6b65aae2

And

https://github.com/discourse/discourse-canned-replies/commit/960b662649c94f5c1443d74995c0a3024d5d09b6

8 Likes
11

This topic was automatically closed after 24 hours. New replies are no longer allowed.