Can't dismiss unread if last post is an assign or whisper

Contribute Bug

AI-generated summary

A bug was reported where the “dismiss” button on the unread tab does not clear topics that end with an assign/unassign or a whisper. awesomerobot reproduced the issue and martin added it to his list. After investigating, martin was able to reproduce and fix the issue for whispers, but not for assigns/unassigns. However, awesomerobot found that the issue may not be consistently reproducible and martin decided to push the fix for whispers. A fix for the issue was merged into the Discourse codebase (https://github.com/discourse/discourse/pull/8271) as reported by martin.

1

I can reproduce this on Meta (team, feel free to impersonate my account to see).

If a topic ends with an assign/unassign or a whisper, the dismiss button on the unread tab doesn’t clear it.

4 Likes
Stuck unread notification
Still getting notifications (from ignored user?)
3

@martin can you add this to your list :slight_smile:

1 Like
4

No problem I will add it!

6 Likes
5

@awesomerobot I was able to reproduce this bug locally and fix when a whisper was the last post in a topic, however if an assign/unassign last action the Unread tab was clearing fine. To try and reproduce I:

  1. Created a topic as one user
  2. Watched as another
  3. Assigned the topic as the first user
  4. Went to the Unread tab as the second user (where the topic came up as unread)
  5. Clicked the Dismiss… button and confirmed the modal

All of the unread items were then cleared. However if I did the same actions except replacing step 3. with creating a whispered reply, I ran into the bug and the Unread list would not clear. Was there anything else I would need to do to reproduce the assigning/unassigning part of this? If not I’ll just get up the fix I have :slight_smile:

3 Likes
6

Hmm, not sure… I just went to clear my unreads again and more of them cleared out … but a few are still lingering. Maybe assign was a red herring.

35%20AM
35%20AM2322×658 145 KB

I can’t consistently reproduce this, so maybe there’s nothing else to be done at the moment.

3 Likes
7

Thanks for that, I will just push up the change to ensure the unread topics are dismissed if a whisper is the last post :+1:

3 Likes
8

A fix for this was just merged FIX: Unread topics not clearing when whisper is last post by martin-brennan · Pull Request #8271 · discourse/discourse · GitHub

5 Likes
9

This topic was automatically closed after 3 days. New replies are no longer allowed.