Impossible de générer des avatars utilisateur lors du passage à un nouveau serveur car l'extension est "inconnue"

Bug
1

EDIT: I’m reclassifying this as a bug, so that someone who understands this better than I can take a look at it.

a bunch of uploads had “unknown” as the extension. This means that it’s impossible to generate thumbnails. I think this happened when moving a backup to a new site and then needed to regenerate the thumbnails.

I think what should happen when you try to generate thumbnails and the extension is ‘unknown’ is to replace the extension, something like

 upload.extension = upload.original_filename.split('.').last

It seems like if this were done somewhere that I’d not have spent 4 hours on this.

Wait. This looks like the problem. Why return false rather than get the extension from the filename?

Gory details follow.

I moved a site from /community to community.example.com by doing a backup and restore. I fixed the uploads with a

 RAILS_ENV=production bundle exec script/discourse remap '/community/uploads' '/uploads'

But the avatars are still the Gray Man.

When I look at user.user_avatar.custom_upload.url and paste that URL into the browser, I get the desired avatar. It seems like I need to “rebake” the users.

I thought that perhaps a

rake avatars:refresh

or

rake avatars:clean

might fix it, but no joy.

What am I missing?

1 « J'aime »
2

In sidekiq there is a trigger to create missing avatars.

It takes a while, but that should help if I am not mistaken

2 « J'aime »
3

Good one! That callls User.refresh_avatar, but sadly

  user=User.find_by_username('broken_avatar_guy')
  user.refresh_avatar

also isn’t solving this.

2 « J'aime »
4

Here’s a clue:

ActionController::RoutingError (No route matches [GET] "/user_avatar/community.example.com/broken_user")
1 « J'aime »
5

Do it update when the user logs into their account ?

6

I don’t believe so.

user.user_avatar.custom_upload has the correct URL, but https://community.example.com/user_avatar/community.example.com/bad_user/25/321_2.png has the missing avatgar image. I need to find the way to rebuild those avatar thumbnails.

7

there is a force_avatar_update in the user login that i saw in the code.

8

this could be very helpful, it looks like a job

9

Something must be wrong:

user=User.find_by_username('Tuomo')
upload_id=user.user_avatar.custom_upload.id
upload = Upload.find(upload_id)
      Discourse.avatar_sizes.each do |size|
        OptimizedImage.create_for(upload, size, size)
      end
OptimizedImage.where(upload_id: upload_id)

ANd I get the no opimized images.

broken_uploads = Upload.where(extension: "unknown")
broken_uploads.each do |upload|
  upload.extension = upload.original_filename.split('.').last
  upload.save
end

fixes that.

Then I just need to generate new thumbnails, like this:


has_upload = UserAvatar.where("custom_upload_id > 0")

has_upload.each do |user_avatar|
  Jobs.enqueue(:create_avatar_thumbnails,{upload_id: user_avatar.custom_upload_id})
end
2 « J'aime »
10

Je pense que c’est un bug légitime et que Jeff :heart:é, mais il n’a pas reçu plus d’attention.

Suis-je fou ou y a-t-il quelque chose qui ne va pas ici ?

2 « J'aime »
11

J’ai déplacé un site de /community vers community.example.com en effectuant une sauvegarde et une restauration.

Je suppose que nous n’avons tout simplement pas rencontré cela avec aucune de nos restaurations, car ce dont vous vous plaignez ici sont des artefacts de restauration, n’est-ce pas ? Peut-être spécifiques à cette sauvegarde et restauration ?

1 « J'aime »