Can't restore a backup if it includes link to Discourse onebox

pfaffman · October 2, 2024, 7:41pm

If you have a site with download images to local unset and it links to a discourse forum and includes a onebox that includes an image with /uploads/default/original in it you can’t restore the database.

github.com

discourse/discourse/blob/main/lib/file_store/to_s3_migration.rb#L78


      
          base_url = File.join(SiteSetting.Upload.s3_base_url, prefix)
          count = Upload.by_users.where("url NOT LIKE '#{base_url}%'").count
          if count > 0
            error_message =
              "#{count} of #{Upload.count} uploads are not migrated to S3. #{failure_message}"
            raise_or_log(error_message, should_raise)
            success = false
          end
          
          cdn_path = SiteSetting.cdn_path("/uploads/#{@current_db}/original").sub(/https?:/, "")
          count = Post.where("cooked LIKE '%#{cdn_path}%'").count
          if count > 0
            error_message = "#{count} posts are not remapped to new S3 upload URL. #{failure_message}"
            raise_or_log(error_message, should_raise)
            success = false
          end
          
          unless Rake::Task.task_defined?(MISSING_UPLOADS_RAKE_TASK_NAME)
            Discourse::Application.load_tasks
          end
          Rake::Task[MISSING_UPLOADS_RAKE_TASK_NAME]

I solved this by putting a space before the oneboxed Discourse link so that it did an inline link rather than a onebox.

Don’t know why they have download images turned off. . .

Topic		Replies	Views
S3 migration error with oneboxed posts Support	0	382	October 19, 2020
Restore failed at "EXCEPTION: x of y uploads are not migrated to S3. S3 migration failed for db 'default'." Installation	4	987	June 10, 2022
Discourse not downloading remote images anymore? Support	7	779	July 4, 2022
Uploads missing after restore Installation	4	652	April 24, 2022
Unable to migrate to S3, therefore unable to restore from backup Installation	3	1130	April 8, 2022

Can't restore a backup if it includes link to Discourse onebox

Related topics