Can't scroll through list of user's groups if more than one page

Contribute Bug

AI-generated summary

A bug was reported where users cannot scroll through a list of groups if the user is in more groups than will fit on a page. pfaffman discovered that the load_more_rows URL does not include the username, causing subsequent page loads to pull from all groups, not just the user’s groups. Although considered an edge case, it is a legitimate bug. tgxworld has since fixed the issue by adding missing parameters to the load_more_groups path, as seen in this commit.

1

If a user is in more groups than will fit on a page, there’s a bug because the load_more_rows URL doesn’t include the username.

Here’s what in https:/FORUM/groups.json?username=some_user

  1. extras:{type_filters: ["public", "close", "automatic"]}
  2. groups:[{id: 552, automatic: false, name: "group_name_one", user_count: 45, mentionable_level: 0,…},…]
  3. load_more_groups:"/groups?page=1"
  4. total_rows_groups:795

And when you scroll down the page, subsequent page loads pull from all groups, not just the user’s groups.

This is an edge case, because who puts users in so many groups?

But it does seem to be a legit bug.

3 Likes
2

edge case, very hard to repro, but we should fix.

2 Likes
4

Would rails commands to create a bunch of groups and add a user to them help?

5

username is an internal filter that we use though so it isn’t meant to be used on the /groups page.

However, it does seem like the load_more_groups path was missing a couple of params in it which I’ve fixed in

https://github.com/discourse/discourse/commit/b4f92a05b347cbaa7bc3482095c5fdefe88393b0

Thank you for reporting @pfaffman :+1:

4 Likes
6

This topic was automatically closed after 24 hours. New replies are no longer allowed.