Échec de la mise en boîte CNN

tgxworld · Mai 8, 2024, 5:33

Ceci est corrigé par

github.com/discourse/discourse

FIX: Attempt to onebox even if response body exceeds `max_download_kb`

main ← fix_dont_throw_away_response_body_when_max_download_exceeded

opened 05:28AM - 08 May 24 UTC

tgxworld

+45 -4

In 95a82d608d6377faf68a0e2c5d9640b043557852, we lowered the default for `Onebox….options.max_download_kb` from 10mb to 2mb for security hardening purposes. However, this resulted in multiple bug reports where seemingly nomral URLs stopped being oneboxed. It turns out that lowering `Onebox.options.max_download_kb` resulted in `Onebox::Helpers::DownloadTooLarge` being raised more often for more URLs in `Onebox::Helpers.fetch_response` which `Onebox::Helpers.fetch_html_doc` relies on. When `Onebox::Helpers::DownloadTooLarge` is raised in `Onebox::Helpers.fetch_response`, we throw away whatever response body which we have already downloaded at that point. This is not ideal because Nokogiri can parse incomplete HTML documents and there is a really high chance that the incomplete HTML document contains the information which we need for generating a reasonable onebox. Therefore, this commit updates `Onebox::Helpers.fetch_html_doc` to not throw away the response body when the size of the response body exceeds `Onebox.options.max_download_size`. Instead, we just take whatever we have and get Nokogiri to parse it.

Localement, les URL « problématiques » signalées dans ce sujet n’affichent plus d’erreur lorsque nous essayons de les onebox.

Sujet		Réponses	Vues
Oneboxing large images fails with no visual cue Bug onebox	47	1545	Mai 4, 2023
Onebox links result in large image downloads Feature	2	473	Décembre 14, 2022
Can't override size of image oneboxes Feature	3	804	Juin 18, 2017
Onebox issue with a specific site Support onebox	14	1623	Mars 2, 2019
Onebox settings being ignored on edits Support	4	559	Mars 24, 2022

Échec de la mise en boîte CNN

Sujets connexes