Common image uploads sizes cropped

[DeanMarkTaylor (Dean Taylor)]

It’s very typical for users to upload images which are screenshots taken on mobile.

Currently the recent changes prevent these mobile screenshots from displaying in a reasonable way.

Cropping to the top of the image is undesirable, unexpected and considered “broken” by users.

Expected

Actual

Sample image here on meta

Additional notes

Please also consider adding a visual indicator on the smaller image when it has been cropped.

[zogstrip (Régis Hanol)]

I noticed this earlier today and just pushed a fix

https://github.com/discourse/discourse/commit/ebd4b4577168644ff1132af85215bfa2034ecdbb

---

@DeanMarkTaylor

Additional notes

Please also consider adding a visual indicator on the smaller image when it has been cropped.

I’m open for suggestions

[cpradio]

I’m open for suggestions

Maybe the crop font-awesome icon?
http://fontawesome.io/icon/crop/

I’m just unsure if you know at the time the lightbox runs that it was cropped versus resized…

[DeanMarkTaylor (Dean Taylor)]

@DeanMarkTaylor

Please also consider adding a visual indicator on the smaller image when it has been cropped.

@zogstrip

I’m open for suggestions

Perhaps something like this which is always displayed on a cropped image:

---

Please also note that for extremely tall images clicking the image and then showing full-screen is a poor solution…

… mainly because you are unable to scroll and you are still limited by the height of the users screen.

Note the result of clicking the image in the first post of the feature request:

Feature Request: Tall and Thin Image Handling

I think this is a feature request. We have users putting images in posts, and sometimes those images are quite tall, i.e. height much greater than the width. Discourse provides an image preview in the post, but uses the image height within the post height to determine the aspect ratio. An example image looks like this: [image] Ideally we’d like to present this image so that the image width takes the full post width, but perhaps shows a ‘More…’ link at the bottom. The ‘image viewer overlay’ (n…

[zogstrip (Régis Hanol)]

Please also note that for extremely tall images clicking the image and then showing full-screen is a poor solution…

… mainly because you are unable to scroll and you are still limited by the height of the users screen.

Note the result of clicking the image in the first post of the feature request:

If you click on the image once it’s full-screen, the image will be “real size” and you’ll be able to scroll