Composer-Vorschau-Seiten zeigen die Steuerungstasten unter den hochgeladenen Videos

awesomerobot · 13. August 2024 um 19:15

Ich habe einen PR vorbereitet, der dies bald beheben wird:

github.com/discourse/discourse

UX: do not check for dimensions in video filename

main ← ux-video-controls

opened 07:14PM - 13 Aug 24 UTC

awesomerobot

+10 -1

When adding a video/image/audio to a post, we check the token content for dimens…ions. If dimensions are found, we assume the content can be resized and give it image controls in the composer preview. The problem is that we check the entire token, including filename, for dimensions. This means if a video has dimensions in its filename, we show broken controls: ![image](https://github.com/user-attachments/assets/93f3bbc9-1c0f-4ac3-b541-aab854624824) This PR updates the `hasMetadata` function so it checks the area dedicated to dimensions specifically, which comes after the `|` in markdown. Now images get the controls, and videos with dimensions in their filename do not: ![image](https://github.com/user-attachments/assets/92d64c52-f4d5-4ecc-9567-c0737f724ae7)

Thema		Antworten	Aufrufe
Make it more obvious an image is resizable when uploading an image UX	10	1141	7. Oktober 2024
100% 75% 50% next to images in preview window UX	2	466	22. März 2024
Is there any way to check I chose the correct video without publishing the topic? Support	1	341	29. Mai 2024
Insert Video icon missing from composer UX completed , insert-video	6	233	24. Juli 2020
Uploading of video file fails due to JS error Bug uploads , fixed	18	765	24. August 2024

Composer-Vorschau-Seiten zeigen die Steuerungstasten unter den hochgeladenen Videos

Verwandte Themen