"currently disabled" even when button shows that

AI-generated summary

The discussion revolves around the desktop notifications button, which displays “Disable notifications” but also shows “(currently enabled)” next to it. Xack finds this redundant and unnecessary. fefrei suggests replacing the button with a checkbox for clearer semantics. However, riking explains that the button has four states, making a checkbox impractical. codinghorror agrees with Xack and removes the “(currently enabled)” string, as the “Disable” text on the button already indicates that notifications are enabled.

The picture above shows that the desktop notifications button is displaying it’s enabled, otherwise it would say “Enable notifications” and not “Disable notifications”. However, there’s a “(currently enabled)” next to it, which feels unneeded since the button shows it’s enabled anyway.

Just a minor nitpick. :smiley:

1개의 좋아요

Can’t we turn this into a checkbox, which has super clear non-duplicated semantics and fits in quite nicely?

1개의 좋아요

Nope, because the button actually has four states. Permission needed, permission denied, permitted but off, permitted and on.

I added the “currently enabled” because the text on the button was confusing me as to what the current state is. If you have better text/icon combinations to use, please reply with them :slight_smile:

2개의 좋아요

I agree with this, the presence of “disable” on the button means it is enabled. So I changed the "(currently enabled)" string to "".

2개의 좋아요