Custom emoji don't use CDN for S3 stored assets in a few pages

Boost · August 6, 2020, 11:42am

I tried fixing this myself after having a quick look.
It seems like the issue is that the discourse JavaScript method buildEmojiUrl receives the storage URL instead of the CDN URL for the custom emoji. Which seems to be the same thing retort plugin also uses.
So by fixing that, it would probably fix all of the problems, right?

After that quick look I found a place that seems to build the URLs for the custom emojis and I changed that to this:

github.com

discourse/discourse/blob/baefef2c63c300892b5c119e5c2e1cfa35636bf7/app/models/emoji.rb#L119


      
                e.group = emoji.group || DEFAULT_GROUP
              end
            end
          end
          
          Plugin::CustomEmoji.emojis.each do |group, emojis|
            emojis.each do |name, url|
              result << Emoji.new.tap do |e|
                e.name = name
                url = (Discourse.base_uri + url) if url[/^\/[^\/]/]
                if SiteSetting.Upload.enable_s3_uploads
                  if url.start_with?(SiteSetting.Upload.s3_base_url)
                    url = url.sub(SiteSetting.Upload.s3_base_url, SiteSetting.Upload.s3_cdn_url)
                  end
                end
                e.url = url
                e.group = group || DEFAULT_GROUP
              end
            end
          end

I tested with rails console and that seems to fix the URLs on my production site. So I tried deploying that change there, however it didn’t work.
After that not working I also tried to change the EMOJI_VERSION to 10 to try to get something updating, but that didn’t work either. When I do launcher enter and git log I see my commit there. I followed the approach here:

Topic		Replies	Views
User cannot use custom avatar with Amazon S3 Bug	42	6342	May 4, 2015
Help restoring - system hung at midnight Installation	26	2200	June 13, 2022
How do custom emoji URLs work? Dev	0	642	August 8, 2020
Rebaking old posts won't pull new S3 CDN URL after S3 bucket rename Installation	14	1658	January 12, 2021
Invalid URL for markdown-it-bundle Installation cdn , s3	5	957	December 13, 2022

Custom emoji don't use CDN for S3 stored assets in a few pages

Related Topics