Date picker arrows almost invisible in dark theme

UX
1

Hi everyone,

Can anything be done about the colour of the ‘previous’ and ‘next’ arrow buttons on the date picker for admin reports?

On the dark theme they are practically invisible :confused:

Other arrows elsewhere on the admin reports pages are clearly visible, as is every other clickable element within the calendar date picker - except the forward / back arrows.

Example:

PNG
IMG_1076.PNG.jpg1536×1032 156 KB

In the default / light theme though, the arrows are clearly visible:

PNG
IMG_1077.PNG.jpg1536×951 141 KB

It is almost as if the arrow colour in dark theme does not change like all the other clickable calendar elements do.

Thanks in advance :+1:t2:

7 « J'aime »
2

cc @awesomerobot to look at

1 « J'aime »
4

I pushed a fix. Since pikaday uses PNGs inline in their CSS, I’m just detecting the brightness of the background color and inverting it. We’d need to rework how pikaday generates the back/next buttons otherwise.

https://github.com/discourse/discourse/commit/8546f0020ee236bef8f8f6d53ad2b5d047bb1b6d

7 « J'aime »
5

Great news, thanks Kris, much appreciated mate :smiley:

6

This topic was automatically closed after 26 hours. New replies are no longer allowed.