Details accepts only one word as summary

Bug
,
1

Let’s try:

this

Lorem ipsum etc.

Yeah, happends here too. It should be this is just a test.

On my forum [details] doesn’t work at all if summary has a space there. Here it works but shows only one word. Broken still.

2 Likes
2 
[details="Summary"]
This text will be hidden
[/details]

I think you need the " "

3 Likes
3

O for f* sake :man_facepalming: And I use that every damn day.

Wait a minute… you almost got me :smirk: I should start trust myself more. I’ve never used ” ” with details.

[details=”This is a test”]
Lorem ipsum etc…
[/details]

2 Likes
4

I think you use the wrong ones. Yours are diagonal. Have you tried to use the composer button?

” instead of "

5

Diagonal, triangular… I don’t care. Those are what I have in Finland and those what I’ve used earlier are now broken.

But let’s try:

Summary is this

This text will be hidden

Yeah, that’s the reason.

But still — it worked earlier, it doensn’t work anymore. Ergo, it is a bug, not UX question or support request :stuck_out_tongue_winking_eye:

3 Likes
6

I can’t say I’ve ever used it without including the quotations marks, but the readme does gives an example of a naked one (discourse/plugins/discourse-details/README.md at main · discourse/discourse · GitHub)

discourse-deatils usage
discourse-deatils usage1179×827 75.2 KB

Not sure what’s changed though that would have an effect on this. :thinking:

2 Likes
8

I just checked and I’ve used both, with and without quotemarks.

But that is not the actual reason as Moin pointed, but it accepts now only straight quotes, not curly ones.

2 Likes
9

I recently merged a somewhat stricter parsing for BBCode tags and it’s no longer allowed to use “values” without spaces. The value has to be surrounded by a pair of quotes if it has any spaces, otherwise they will be considered as different “parameters”.

Since the “pair of quotes” are somewhat different in various languages, I’ve only added what I thought was the most common ones.

I’ll have a look at the pair used by @Jagster.

Since the [details= plugin is somewhat popular with only one parameter, I will add a check for it so it can use values with spaces even though there are no quotes.

2 Likes
11

Quotes are totally acceptable, but then curly ones should work too. It is quite common that straight ones will change to curlies, and straights are thing to devs only :wink:

Do I remember right that even Discourse has settings for that?

Anyway, in most keyboards default is curly, not straight — at least on virtual side.

12

Americans use mostly straight quotes. It’s everyone else who has different opinions :sweat_smile:

1 Like
13

Both issues will be fixed by :point_down:

4 Likes