Difficulty understanding the enable welcome banner setting

martin · August 12, 2025, 4:19am

Merged the fix now, it took a while longer because I needed to figure out how to test it:

github.com/discourse/discourse

FIX: Theme site settings not reloading across processes

main ← issue/fix-multi-process-tss-cache

opened 02:27AM - 12 Aug 25 UTC

martin-brennan

+86 -4

This commit fixes an issue in multi-process setups where the following would ha…ppen: 1. Admin changes a theme site setting. The new value is stored in memory in the process that made the change. For this example, changing `enable_welcome_banner` from `true` to `false` 2. Another user visits the site and hits another process, which has the old value of `enable_welcome_banner` still set to `true` in memory 3. The other user's value for `enable_welcome_banner` is cached in the cache for theme site settings, which is shared across all processes The issue is fixed by doing the same thing as site settings: when the new value is saved, we send a MessageBus message to all processes via `SiteSettingExtension` which calls `refresh!` and reloads the in-memory cache of theme site settings from the DB. c.f. https://meta.discourse.org/t/difficulty-understanding-the-enable-welcome-banner-setting/377321

I will deploy your site soon Moin.

Edit: Fix has been deployed

Topic		Replies	Views
Welcome Link Banner Theme component official , welcome-link-banner	42	14829	July 9, 2025
Versatile Banner Theme component official , versatile-banner	97	42839	August 28, 2025
Advanced Search Banner Theme component official , advanced-search-banner	61	22133	August 26, 2025
Themeable site settings are now available Announcements	5	308	July 23, 2025
Alien Night Theme - A free Dark Theme for Discourse Theme	78	27254	February 4, 2025

Difficulty understanding the enable welcome banner setting

Related topics