Desabilitando email na restauração de backup

Funcionalidade
1

It’s great that outgoing email gets suspended when a backup is restored, along with a suitable site notice to remind the admin to switch it on.

Should / could this be extended to override POP polling too, incase that was setup and starts consuming messages?

This would be helpful where the settings “pop3 polling enabled” and “pop3 polling delete from server” are both set.

4 curtidas
2

Yes, I second that.

It would be great if there was a “don’t reach out to any external service” mode that disables all external actions that have a permanent effect on the world outside the forum, like outgoing emails (except for those that are really essential), POP3 delete from server and triggering webhooks.

5 curtidas
3

Yep - a sort of ‘isolation mode’ so that you can do a test restore of a backup (as is good practice from time to time) without any worry of impacting the running instance, or during migration you can stand up the new instance and check it over safely before making the switch (presuming the source site is in read-only mode or down etc…).

2 curtidas
4

Good point, any thoughts on this @gerhard?

2 curtidas
5

I agree. An “isolation mode” would be a useful feature. Not just after restores.

For now, something similar could be done with a simple plugin. Something like the following should work:

# name: isolation-mode
# about: Enables isolation mode after restoring backup.
# version: 1.0

after_initialize do
  on(:site_settings_restored) do
    SiteSetting.pop3_polling_enabled = false
    WebHook.update_all(active: false)
  end
end

As an alternative, you could also use the discourse restore CLI command and update site settings and whatnot afterwards with the rails runner.

3 curtidas
6

Este ainda é o melhor conselho?

7

Sim, nada mudou. Não há um recurso de "modo de isolamento", portanto, desabilitar mais do que o e-mail de saída não pode ser feito na restauração porque não há como notificar os administradores sobre isso e dar a eles uma opção fácil para reativar tudo.

1 curtida
8

Adicionei isso ao meu próprio repositório (creditando @gerhard, é claro!).

Coisas que adicionei:

  • disable emails: sim
  • login required: true

E pronto, ao concluir a restauração de um backup:

image
image1110×515 29.5 KB

Isso realmente salva vidas para hospedar versões de staging sensíveis com e-mails reais de usuários…

Obrigado novamente!

1 curtida