Disclosure of S3 secret access key

Yeah – I’ve got a thread elsewhere where I’m being persnickety about exactly what the permissions the S3 user should have. (Though now that I’m reminded this is a thing, there’s no reason I shouldn’t add an IP blocker to the role.) Far as security goes, anybody able to execute code as Discourse’s user can, well, execute code as Discourse’s user, so they’re as likely to be able to grab the credentials from Discourse as they are the instance metadata.

Exactly, and then @techAPJ you can use this site setting type to automatically set the type of the input to password to hide the content and add a Show value button that will toggle the type of the input :wink:

6 Likes

This is now done via:

https://github.com/discourse/discourse/commit/46fc57222f24add74d2d075eb36663565967622c

Demo:

11 Likes