This would have been a lot simpler imo, but don’t wanna break existing apps . Leave SSO instance generation up to the user.
# frozen_string_literal: true
module DiscourseApi
module API
module SSO
def sync_sso(sso)
post("/admin/users/sync_sso", sso.payload)
end
end
end
end
Maybe tomorrow I’ll do something like (but neater)
# frozen_string_literal: true
module DiscourseApi
module API
module SSO
def sync_sso(params)
if params.instance_of?(DiscourseApi::SingleSignOn)
post("/admin/users/sync_sso", sso.payload)
elsif params.instance_of?(Hash)
.... same as current
end
end
end
end
end
Thoughts? My app will ideally have a single function that generates DiscourseApi::SingleSignOn, and I’d then be able to pass it to sso_login or sync_sso