Discourse_api sync_sso custom_fields results in "custom.custom.<field>" in payload

https://github.com/discourse/discourse_api/pull/190

DiscourseApi::SingleSignOn expects custom attributes to be assigned like

sso.custom_fields['field_1'] = 'value'

# which results in `custom.field_1` key in payload

DiscourseApi::API::SSO.sync_sso() expects params to have

{ 'custom.field_1' => 'value` }

But it passes in the custom. prefix to sso.custom_fields
This results in the payload to having

custom.custom.field_1

Also added some test overkill for sync_sso

1 Like

This would have been a lot simpler imo, but don’t wanna break existing apps :grimacing:. Leave SSO instance generation up to the user.

# frozen_string_literal: true
module DiscourseApi
  module API
    module SSO
      def sync_sso(sso)
        post("/admin/users/sync_sso", sso.payload)
      end
    end
  end
end

Maybe tomorrow I’ll do something like (but neater)

# frozen_string_literal: true
module DiscourseApi
  module API
    module SSO
      def sync_sso(params)
        if params.instance_of?(DiscourseApi::SingleSignOn)
          post("/admin/users/sync_sso", sso.payload) 
        elsif params.instance_of?(Hash)
          .... same as current
        end
      end
    end
  end
end

Thoughts? My app will ideally have a single function that generates DiscourseApi::SingleSignOn, and I’d then be able to pass it to sso_login or sync_sso

Or params can be defined like

{
  sso_secret: ...
  name: ...
  custom_fields: {
    field_1: ...
  }
}

Which would also break existing apps.

2 Likes

A fix was made for this last month:

2 Likes