It would be really nice to use Discourse for embedding comments while still supporting google AMP on my content pages.
Disqus was another option, but I really like Discourse for community building and I think you guys have a better product. Are there any plans to support an AMP friendly embed feature?
My site is relatively new and so I made the (easy) decision to support Google AMP from the start. This required only a simple server side script to replace img/iframe tags in the html and css with amp tags when rendering urls with /amp.
The problem I am having is that discourse comments require javascript to be inserted into the head of the document in order to correctly format the discussion iframe and handle requests. This does not mesh with AMP at all.
I tried using an iframe directly instead of the embed script, but none of the links worked and the sizing on the iframe was messed up. This was all handled by javascripts/embed.js it seems.
I am open to some tinkering and/or server side configuration of the iframe element but I think many people would appreciate this being supported out of the box.
It also sounds like the changes you need to make are on your server side, to pull in posts from Discourse and render them, rather than having them pull in dynamically. Discourse has a solid API for that kind of thing, so you’ll probably just have to do a bunch of programming on whatever generates your pages.
This is specific to embedding so it’s a valid request but the answer is pretty much “no, impossible”. Though our embed comments are fairly simple, I don’t think we could do absolutely JS free.
AMP friendly in this case likely means a server side javascripts/embed.js such that a script does not need to be pasted into the body of the target page and appended to the head. The current functionality is very dependent on client side processes.
For example, it would solve the problem if I could include a <iframe src="discourseurl/embed-comments?embed_url=myurl"></iframe>
I got pretty close to this functionality, but none of the links work and I am bypassing your validation.
I did read the post @sam linked before making the suggestion. This seems a lot more reasonable than the entire platform supporting AMP, though I understand the reservations.
Sort of. There are some limitations (of course) but this allows people to embed arbitrary scripts into their AMP content pages. The main thing is the scripts cannot modify the parent AMP document, so Discourse’s script being appended to the head is a no go.
I was hoping to avoid any heavy integrations via API as @mpalmer suggested, but with the current functionality this is the only option I see aside from using another 3rd party solution for comments.
Putting the entire comment embed block into an additional iframe almost does the job, but fails validation in javascripts/embed.js. This was probably not a good solution anyway, but worth mentioning.
I just feel like heavy integration is far more in the spirit of what they want at Google, further more it gives you a significant sell internally over disqus which is another win
Yeah its great you guys offer an API. I’ll need to look over it and decide how much work is required to get it up and running. I’ll post my results if I end up doing it.
I do think a self-contained iframe would be better, though, so I’m going to dig a little deeper on that.
Iframe method would offer:
No stale comments in AMP cache (presumably)
Future improvements to Discourse embed functionality automatically supported
Easy integration without use of API for those that want to support AMP on pages with Discourse comments. Just change iframe tag to amp-iframe
This won’t help you unless you’re using WordPress for your site. After reading this topic I tried out the WP Discourse plugin combined with the Automattic amp-wp plugin. I’ve only tried this on a development site, but it seems it can be made to work by adding a function to WP Discourse that appends the comments template directly to the post content when a request is made for an AMP page.
Here’s the output after making a few css changes for AMP pages (this could be improved.)
I’m not using Wordpress for this but I did look over that plugin for ideas. Cool that you got it working on your site @simon !
@sam I just got the embed working by bypassing the javascripts/embed.js logic completely. I still need to handle the iframe sizing issue but all of the functionality seems to be good. Basically I used the output from javascripts/embed.js with some additional sandbox settings.
I just swap this out with amp-iframe for amp pages.
The main question in my mind is “Should I be doing this?” Looking over javascripts/embed.js again, I am mostly missing out on the iframe sizing and url normalization, but if that script changes I’ll be none the wiser.
