Discourse Gifs component

orenwolf · April 3, 2021, 4:43pm

Ironic considering who created the webp format, and who now owns Tenor.

Falco · April 4, 2021, 2:47am

Maybe they go straight for animated avif ? It’s already live on Chrome, and will be soon everywhere modern.

I added it to this post above, the file size is amazing:

anon82467725 · April 4, 2021, 12:12pm

How is development of that format going? How long do you think it’ll take for other companies to adopt it (including Discourse )?

Falco · April 4, 2021, 12:51pm

Discourse can support it easily as soon as browser support happens: Can I use... Support tables for HTML5, CSS3, etc

anon82467725 · April 4, 2021, 7:26pm

I guess we are just waiting on Microsoft Edge then. It can be enabled in Mozilla Firefox.

Falco · April 6, 2021, 8:20pm

Thanks to @eviltrout we now render the GIF button in a better place in mobile so this won’t happen anymore!

mstm · April 7, 2021, 12:27am

Thanks @Falco , is it possible to hide the gif button while previewing the message?

Thanks

Richie · April 6, 2021, 8:53pm

I’m not that familiar with theme components, is it possible to enable this on only one category?

We have a random / off topic / fun category where this would be a brilliant addition, but if I add it to all categories then all hell will let loose

Steven · April 6, 2021, 9:06pm

You could try with css but since the composer stays open when we navigate on the forum, I’m not sure it would work 100%

It would be something like this

:not(.category-your_category_id) .d-icon-discourse-gifs-gif-icon {
    display: none
}

Falco · April 6, 2021, 9:21pm

Good idea. Added it in last version, please update!

Eduardo_Braga · April 7, 2021, 4:46am

activated and here do not display for mobile, only for desktop

forum.meuxbox.com.br

Falco · April 7, 2021, 5:16am

You need to update Discourse to latest as the support for the button in the footer was just added today.

mstm · April 7, 2021, 9:31am

Hi @Falco with some devices (iPad and tablet) the gif button is hidden, check also here on meta.

Terrapop · April 7, 2021, 10:33am

We have updated Discourse to the latest version, the button for GIFs is now missing both on desktop and mobile.

Same JS error here on meta BTW. Chrome desktop.

mstm · April 7, 2021, 10:07am

Yes @Terrapop but in my case all plugins are gone after update, not just this one

Terrapop · April 7, 2021, 10:47am

Yes, in addition we see strange Javascript problems after the update with variables declared in our JS code like:

xxx = 39392;

instead of

var xxx = 39392;

The former (non-strict declaration) is throwing “undefined variable” errors after the update to the latest Discourse version. We had to change all those instances in our code, to get our scripts working again.

Have there been any changes made to how JS in components is processed in Discourse?

@codinghorror

Ludovik_Dopierala · April 7, 2021, 11:41am

Hello

After reboot the plugin seems to be broken. Can’t see GIF button anymore.
I have the message into the log :
Error: Could not find module discourse/helpers/gif-modal imported from discourse/theme-5/initializers/gif-integration
Url: https://www.cmstrategies.fr/assets/ember_jquery-36a23101c869ab0dc53fc908de69adb785731593573d32bdeef416acc1076ef4.js

AquaL1te · April 7, 2021, 12:22pm

Maybe it’s related to this: Some theme components do not work after upgrading Discourse

Ludovik_Dopierala · April 7, 2021, 12:58pm

@Terrapop same here

Some one have already fix it ?

pmusaraj · April 7, 2021, 1:39pm

Please follow Some theme components do not work after upgrading Discourse, it’s an issue with several theme components (not just Gifs). We are working on a fix.