[image] How to install discourse without ssl? ./discourse-setup will serve http pages if you don’t provide an email address for let’s encrypt I don’t think that’s the case anymore. FEATURE: Default to HTTPS committed 08:34PM - 02 Dec…

Exactly @jomaxro . That is why I said [image] How to install discourse without ssl? Yes, but that requires not using the ./discourse-setup script and editing your app.yml manually.

Oh. Sorry. I missed that change. So if the user does not provide a let’s encrypt notification email address, discourse-setup now blindly enables let’s encrypt without verifying that the domain resolves to the current server. But if you do provide an email address then it does the check. This doesn’…

[image] pfaffman: now blindly enables let’s encrypt without verifying that the domain resolves to the current server. But if you do provide an email address then it does the check. No that’s not how let’s encrypt works. The email has nothing to do with domain validation. It’s used to alert th…

[image] Stephen: No that’s not how let’s encrypt works. No. It’s how discourse-setup works, or used to. It used to protect users from requesting a certificate when it was pretty sure that it would fail. Now, it’ll move ahead, request a certificate when it can’t possibly succeed, and not have …

Again, why would it fail? Email isn’t a requirement for domain verification. Failure never generated an email either. The email is only there to tell the user later on if Let’s Encrypt is failing to renew and a cert is due to expire. If the cert renews without problem they’ll never see an email.

[image] pfaffman: blindly enables let’s encrypt without verifying that the domain resolves to the current server I don’t think that was the intent of the change. The intent was to enable SSL regardless of if an email is provided. We should still check the domain resolution cc @Falco

It will fall if the domain name doesn’t resolve to the host. The email address doesn’t matter, but if there is one Discourse setup will warn the user if the address doesn’t resolve.

Domain resolution must pass @falco , otherwise setup should halt… this is a bad change.

[image] codinghorror: Domain resolution must pass @falco , otherwise setup should halt So I made some changes in a branch. Here is how it is going to work: Using a wrong hostname: root@droplet:/var/discourse# ./discourse-setup Hostname for your Discourse?: bad-domain.com Checking your doma…

Commentary on why this change was needed in the first place First, I’m surprised that in the nearly 3 months since this has been this way there haven’t been lots of complaints, and even the topic that brought this to my attention wasn’t having trouble because of this change, so maybe it matters much…

Script de configuration de Discourse : validation du nom d'hôte pour Let's Encrypt

Dev

Falco (Falco) Février 17, 2020, 11:51 2

Exactly @jomaxro. That is why I said

3 « J'aime »

Sujet		Réponses	Vues
Set up HTTPS support with Let's Encrypt Self-Hosting how-to , domains	2	109953	Février 25, 2024
Installed without error but site wont come up Self-hosting	12	1877	Février 13, 2017
No connection accepted on http / https after fresh installation on Ubuntu 22.04 LTS Self-hosting	5	2363	Décembre 16, 2022
After Discourse installation can’t reach it in browser Self-hosting	24	4046	Septembre 5, 2020
Using a certificate when Discourse is installed behind a reverse proxy Self-hosting unsupported-install	24	4970	Mai 17, 2019

Script de configuration de Discourse : validation du nom d'hôte pour Let's Encrypt

Sujets connexes