Discussion Forum Schema improvements

[rrit (Ayke)]

@rrlevering

Let me write some pseudocode for the current check that is displayed in Search Console. […]

    if not (IsDeletedContent() OR IsExternalContent())
       then if not ("text" OR "articleBody" OR "sharedContent" OR "image" or "video")
         then report(OneOfThreeRequired("text", "image", "video"))
   […]

[…]

If the DiscussionForumPosting is referencing content on a different page (like on the original page of multi-page content) it can just have a stub that holds whatever (like the OP topic title) and then references the first page URL. That’s the IsExternalContent() check which is just checking whether url != page URL.

@rrlevering On this “no need for text-attribute on follow-up pages” / IsExternalContent()-check:

I have this test-case on a live-domain:

Discourse implements DiscussionForumPosting on …

• first page - page URL: https://example.org/t/-/12345
  • attribute url: https://example.org/t/-/12345
  • attribute text: – set –
  • attribute author: – set –
• page=2 - page URL: https://example.org/t/-/12345?page=2
  • attribute url: https://example.org/t/-/12345
  • attribute text: – not set at all –
  • attribute author: – set –

Result: Google Search Console (Live test)

• first page:
  DiscussionForumPosting valid
• page=2:
  DiscussionForumPosting invalid
  • 1 critical issue– Either "text", "image", or "video" should be specified

So either there is no check on IsExternalContent() here or the check assumes page URL equals attribute url for

• page URL:
  https://example.org/t/-/12345?page=2
• attribute url:
  https://example.org/t/-/12345

So for now we have to repeat the attribute text on follow-up pages to get a valid DiscussionForumPosting on Google Search Console.