it would be nice if a remote theme page contained a direct link to the respective Github repo.
There is a link “About theme” which typically leads to a topic here on meta (where the link to github can be found) and the License link would typically link to the github repo. However, both of these are useless if you happen to fork a theme and make local modifications.
Maybe something like this could work?
Alternatively, the link could be below the Check updates button.
Also, now that we can import from specific branches, the branch itself should be displayed as well or at least the link to Github should go to that branch.
I will probably need a Handlebars helper to create a proper Github link for non-default branch, but I do not know where to put the code. I will need something like this:
Handlebars.registerHelper('getGithubUrl', function(baseUrl, branch) {
if (! branch) {
return baseUrl;
} else {
// strip '.git' from the end, it is added there automatically in GitImporter
var url = str.substring( 0, str.indexOf( ".git" ) );;
return url + '/tree/' + branch;
}
});
Sorry for noob questions, any pointers will be highly appreciated.
One quick note here, I am not too easy baking “GitHub” into our UIs here, we want to allow diversity here, if people want to use bitbucket or gitlab for themes it is A-OK.
Une petite amélioration serait toutefois la bienvenue. Le lien pointe toujours vers la branche par défaut, même si le thème a été importé depuis une branche personnalisée.
J’ai essayé maladroitement de corriger cela, mais je n’ai pas tout à fait réussi. J’ai soumis une PR en brouillon au cas où quelqu’un serait disposé à aider ou à reprendre le travail. Merci !
