⬇️ Dropdown Header

[j.jaffeux (Joffrey Jaffeux)]

@Arkshine I think DEV: Resolve compatibility with upcoming core changes · paviliondev/discourse-dropdown-header@62649eb · GitHub broke the behaviour here.

I would have wanted to do a PR but Im not even sure what is the expected behaviour on mobile when you cant hover and a header link can have a URL how do you collapse/expand a header link section?

[Arkshine]

From what I recall, this behavior was present before the PR. I think I forgot to fix it (it might be because I did not know hwo to adress it yet).

It can be confirmed here. Clicking on the header will redirect if a URL exists.

javascripts/discourse/widgets/custom-header-link.js.es6

The expand/collapse never worked on mobile view.

What I propose:

• To avoid introducing a behavior change, I suggest hiding the arrow icon on mobile view to prevent users from thinking they can expand or collapse sections. The expanded state should be the only option since the functionality was never implemented.

  • On a side note, since you have setting to show/hide the arrow icon, you can’t dissociate a click on the header title and arrow.

• Perhaps we could enable the expand/collapse functionality on mobile only when no URL is assigned and clearly document that both options cannot coexist. Additionally, I think having a URL in the header with a dropdown may confuse users, as it’s not immediately obvious that you can click on the title, so I would encourage the admin not to do that.

Let me know what you think.

[j.jaffeux (Joffrey Jaffeux)]

@Arkshine

What I propose:

• To avoid introducing a behavior change, I suggest hiding the arrow icon on mobile view to prevent users from thinking they can expand or collapse sections. The expanded state should be the only option since the functionality was never implemented.
  • On a side note, since you have setting to show/hide the arrow icon, you can’t dissociate a click on the header title and arrow.
• Perhaps we could enable the expand/collapse functionality on mobile only when no URL is assigned and clearly document that both options cannot coexist. Additionally, I think having a URL in the header with a dropdown may confuse users, as it’s not immediately obvious that you can click on the title, so I would encourage the admin not to do that.

Let me know what you think.

Yes Im very much aligned with this

[Arkshine]

For reference (I forgot to post here ), I made a PR a week ago:

DEV: Improve header dropdown toggle on mobile view

Hopefully, someone can review it soon.

[N_K_cc]

@Arkshine is the PR approved yet, do we know when the update will go live. Thank you. cc @djordje.vucinic

[Arkshine]

@angus Sorry to ping you! Is there a chance you could take a quick look at the PR when available? Thanks!

[SbadaKesi]

A very nice piece of work. There’s one uncertainty that may or may not be an issue: when clicking the dropdown arrow on the mobile end, the page automatically scrolls to the top.