Editting an assigned post re-sends the assigned mail

AI-generated summary

The discussion revolves around the issue of Discourse re-sending assigned post notifications when a post is edited. carlokok believes this is unnecessary if the post is still assigned to the same person. However, pfaffman points out that notifications are useful if the edit changes the assignment. carlokok clarifies that he is referring to automatic assignments triggered by mentions, like @username, in posts. He notes that editing such posts results in repeated “user assigned a post to you” notifications. sam agrees that this is an issue and asks gerhard to address it, who responds that the issue should be fixed by a specific commit in the discourse-assign repository.

When having a post that’s assigned to user X, Discourse re-sends the user Y assigned post to you to user X. imo it shouldn’t resend that if it’s still assigned to the same person. (This is a post with @X in it)

What if the edit completely changes what the assignment is?

then a mail would be great of course.

1 Like

You mean the automatic whisper post we insert in the stream? Curious why are you editing it?

No I mean a post like this one with @carlokok in it. On our forum that will automatically assign the post to me (which is great), but If I edit this post again, I get another “user assigned a post to you” notification for every time it gets edited.

2 Likes

@gerhard can you add this to your list, not urgent at all but we should clean it up (in theory if we edit this in 15 minutes you will get another notification)

In theory another notification fired

3 Likes

This should be fixed by FIX: Do not assign the same user more than once · discourse/discourse-assign@a308e2a · GitHub

Note: We already prevent duplicate assignments in the AssignController, but that doesn’t work for auto assign.

6 Likes

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.