Entrar en "ga" siempre abre las asignaciones de un usuario, incluso cuando no puede acceder a ellas

Firepup650 · 10 Mayo, 2024 22:53

This is reproducible anywhere with Discourse assign, including here. Just enter ga when not in a text box and the bind triggers, regardless if you’re allowed to do so or not.

Arkshine · 11 Mayo, 2024 00:02

Good catch

github.com

discourse/discourse-assign/blob/main/assets/javascripts/discourse/initializers/extend-for-assigns.js#L758


      
              pluginId: PLUGIN_ID,
          
              actions: {
                save() {
                  this.saveAttrNames.push("custom_fields");
                  this._super(...arguments);
                },
              },
            });
          
            api.addKeyboardShortcut("g a", "", { path: "/my/activity/assigned" });
          }
          
          const REGEXP_USERNAME_PREFIX = /^(assigned:)/gi;
          
          export default {
            name: "extend-for-assign",
          
            initialize(container) {
              const siteSettings = container.lookup("service:site-settings");
              if (!siteSettings.assign_enabled) {

That line might need to be moved inside a api.getCurrentUser()?.can_assign condition.

Tema		Respuestas	Vistas
`assigns public` displays inaccessible link to non-staff users Bug assign	1	366	16 Marzo 2023
Assign not respecting being disabled Bug assign	3	2483	3 Diciembre 2018
"Public assigns" shows reassign button? Bug assign	2	456	28 Abril 2022
Assign topics to non-staff users Feature assign	27	4737	7 Julio 2021
Can no longer submit from assignment comment :cry: Bug assign	2	221	25 Abril 2024

Entrar en "ga" siempre abre las asignaciones de un usuario, incluso cuando no puede acceder a ellas

Temas relacionados