Entrez "ga" ouvre toujours les devoirs d'un utilisateur, même lorsqu'ils sont inaccessibles

Firepup650 · Mai 10, 2024, 10:53

This is reproducible anywhere with Discourse assign, including here. Just enter ga when not in a text box and the bind triggers, regardless if you’re allowed to do so or not.

Arkshine · Mai 11, 2024, 12:02

Good catch

github.com

discourse/discourse-assign/blob/main/assets/javascripts/discourse/initializers/extend-for-assigns.js#L758


      
              pluginId: PLUGIN_ID,
          
              actions: {
                save() {
                  this.saveAttrNames.push("custom_fields");
                  this._super(...arguments);
                },
              },
            });
          
            api.addKeyboardShortcut("g a", "", { path: "/my/activity/assigned" });
          }
          
          const REGEXP_USERNAME_PREFIX = /^(assigned:)/gi;
          
          export default {
            name: "extend-for-assign",
          
            initialize(container) {
              const siteSettings = container.lookup("service:site-settings");
              if (!siteSettings.assign_enabled) {

That line might need to be moved inside a api.getCurrentUser()?.can_assign condition.

Sujet		Réponses	Vues
`assigns public` displays inaccessible link to non-staff users Bug assign	1	366	Mars 16, 2023
Assign not respecting being disabled Bug assign	3	2483	Décembre 3, 2018
"Public assigns" shows reassign button? Bug assign	2	456	Avril 28, 2022
Assign topics to non-staff users Feature assign	27	4737	Juillet 7, 2021
Can no longer submit from assignment comment :cry: Bug assign	2	221	Avril 25, 2024

Entrez "ga" ouvre toujours les devoirs d'un utilisateur, même lorsqu'ils sont inaccessibles

Sujets connexes