Error when creating a new Badge

[Richie (Richie Rich)]

I have an issue when creating a new Badge on my Discourse v2.4.0.beta1 +7

I did compare to latest: https://github.com/discourse/discourse/compare/34f382b…dc5eb76 but saw no mention of a Badge fix, hence this bug report.

Steps to reproduce:

1. Fill in the relevant parts of the form and click Save button

2. The message ‘Saving…’ appears, and does not then disappear:

3. A console error is caught re ace.js

4. Clicking away from the page throws a browser message asking if I’m sure I want to leave that page

5. The badge does get created successfully

Able to reproduce on both Safari 12.1.1 and Firefox 65.0.1

[sam (Sam Saffron)]

Confirmed! Thanks heaps for the report. @techAPJ can you investigate and fix.

If this impacts “stable” we should back port the fix.

[techAPJ (Arpit Jalan)]

Taking a quick look at this, the create (Save) process fails if there is no badge query present. Fixed via:

https://github.com/discourse/discourse/commit/ccb3ba509defff2d74944c92195da7362c4979b1

Backported to beta and stable.

[Richie (Richie Rich)]

Thanks for the quick fix @techAPJ