Expanding topic actions displays who liked the posts but nobody has liked it

Hi,

What happens

On Meta when I press the thee dots to expand the post action menu, although nobody has liked my post, it shows the text as you can see in the picture.


What should happen is that when you go to expand the menu, if nobody has liked the post the text shouldn’t show.

4 Likes

I looked at it and it’s related to a recent PR (yesterday): A11Y: read who liked/read a post when count clicked (#31549) · discourse/discourse@5312550 · GitHub


A quick test shows the issue is here.
The users array should be tested against its length.

4 Likes

Yikes good catch, we will get this sorted this week

2 Likes

Thanks! will be fixed by FIX: only show small user list if users has length by awesomerobot · Pull Request #31631 · discourse/discourse · GitHub

3 Likes