Few minor issue with dropdowns

AI-generated summary

The discussion revolves around minor issues with dropdowns in Discourse. Don initially reported five issues, including alignment problems and incorrect dropdown positions on mobile.

awesomerobot merged a fix for most of the issues, but the problem with dropdown position on mobile remained. joffreyjaffeux suspected it was related to popper, but couldn’t reproduce the issue.

After some investigation, Don found that the issue occurred on Android 10 with Chrome 92.0.4515.166. joffreyjaffeux couldn’t reproduce it, but Don discovered that the problem was caused by using a small display size on the phone.

joffreyjaffeux acknowledged the issue, but deemed it low priority. However, Don later reported that the issue had been fixed, attributing it to a commit by @pmusaraj.

Hello,

I notice some minor align issue with dropdowns.

  1. On the user page the user notification dropdown header.
    Screenshot 2021-08-28 at 15.06.50

  2. Same place but the dropdown and only on mobile.

  3. On mobile the dropdown position not correct on few place.

  4. Top pages dropdown arrow position on Safari

  5. Top pages after click on hover

8 Likes

We just merged a fix here

https://github.com/discourse/discourse/pull/14199

This covers everything except

I think this has to do with popper @j.jaffeux? not sure how to approach that

7 Likes

I can’t repro this. On what device do you repro this? This is in safari or DiscourseHUB? (I can’t repro on any of them FWIW).

This is on Android 10 Chrome 92.0.4515.166

1 Like

I have only Chrome 91 available, but no repro on Android 10/11 so far.

2 Likes

Ahh ok I found it I think. It cause the phone Display size settings. I use it on small size. Now I set it to default and works fine. This is happening on Small Display Size only.

1 Like

Ok I see, we can repro, will have a look, but it’s going to be low priority.

2 Likes

Hello,

The last issue with dropdown (what I reported before) has been fixed now. :arrow_down: :clap:

I believe the fix in @pmusaraj huge commit: UX: Normalize sizing for inputs, buttons, dropdowns (#14226) · discourse/discourse@24e71ac · GitHub

Thank you for everyone! :heart:

1 Like