Glitch with username link in profile card

خلل
1

Just noticed the following behavior:

  • In any topic or PM, click username or avatar to open profile card
  • Hover over username/avatar — URL destination preview (i.e. in lower left in Chrome) shows as current topic URL, not user profile
  • Despite the wrong URL showing on hover, clicking directly still brings me to the user profile
  • However CMD + click opens the current topic (same page) in a new tab, rather than the user profile as expected

I tend to use CMD + click to open user profile in a new tab pretty often so I think this is a recent regression. This happens on two different forums I run + Meta, and in multiple different browsers.

5 إعجابات
2

@Johani any idea why you removed the content of the href attribute in the user card?

إعجاب واحد (1)
3

There was some weird things going on because you had both an action doing some routing and a href doing something else, can’t remember exactly but something was not right. Will look at this.

إعجابَين (2)
4

Ok, I think it was misbehaving before (mostly some tests were failing), but other changes we made in this PR actually make it possible to have this.

https://github.com/discourse/discourse/commit/974007a3cc3e0bef9ec2c2f5d11cf55fece66724

Thanks.

8 إعجابات