Header-Untermenü-Themenkomponente schiebt unteren Teil der Seitenleiste aus dem Bildschirm

awesomerobot · 17. Mai 2023 um 21:39

Dies wurde hier implementiert (vielen Dank an @david):

github.com/discourse/discourse

UX: include custom headers in `--header-offset`

main ← custom-header-offset

opened 06:19PM - 11 Apr 23 UTC

awesomerobot

+39 -14

In a theme component I've been trying to compensate for a custom header in CSS b…y adding to `--header-offset` but this doesn't cover when `headerOffset()` is used in JS: https://github.com/discourse/discourse-header-submenus/blob/b5661b04839a1e9b78eaf25541422f324b96eac6/desktop/desktop.scss#L18 I documented the need for this earlier over here: https://meta.discourse.org/t/header-submenus-theme-component-pushes-bottom-of-sidebar-out-of-the-screen/255496/2?u=awesomerobot So here I'm checking the distance of the `.d-header-wrap` from the top of the page, and adjusting on scroll so this covers both sticky and non-sticky custom headers. Previously this was covered here in `minimumOffset` (deprecated): https://github.com/discourse/discourse/blob/392bafcd7e6427964510b01b36fac9c489244e99/app/assets/javascripts/discourse/app/lib/offset-calculator.js#L21 but it didn't make it over to `headerOffset`

Dies sollte Probleme mit der Seitenleiste, dem Chat und anderen Inhalten des benutzerdefinierten Headers lösen.

Thema		Antworten	Aufrufe
How to finely scroll out custom header? UX	8	2347	31. August 2019
The component pushes down the chat, hiding partially the chat input Bug header-submenus	4	268	5. Juli 2023
Stick header in proper scroll position when having a custom fixed topbar on top of it Support	7	3268	2. Mai 2022
--header-offset with disposable top bar Dev	0	259	22. November 2023
Brand Header making main header jerky on scroll Bug brand-header	9	51	18. Juni 2024

Header-Untermenü-Themenkomponente schiebt unteren Teil der Seitenleiste aus dem Bildschirm

Verwandte Themen