Help us test the rewritten Composer

feature
44

Emojii box is a bit misaligned (Chrome):

Checked: okay in Firefox.

2 Likes
45

Thanks! @eviltrout, I got it to work with the new composer. On to the next plugin! :smile:

5 Likes
46

@eviltrout, so I have my next plugin inserting text, Iā€™m just not convinced Iā€™m doing it how it was designed.

My initializer

and my controller

Iā€™ve highlighted the parts that Iā€™ve adjusted/added. Like I said, it works, but for some reason, I think it should be slightly different than the approach I tookā€¦

If you have a moment to take a look and offer a suggestion, Iā€™d really appreciate it!

47

iPad composer behavior is problematic, composer appears and then disappears immediately (at least in landscape)

48

The pop up for adding links appears inside the composer instead of the main page:

Screen Shot 2015-11-07 at 09.43.20.png2482Ɨ520 55 KB

The link insertion is also flawed. If I mark this text to be linked and enter a link for it I should get [this text to be linked](http://example.com) but it replaces the highlighted text with the link as such: [http://example.com](http://example.com)

4 Likes
49

Here is a fix for the selected text to link
https://github.com/discourse/discourse/pull/3891

4 Likes
50

I donā€™t want to ask too much of you all, but what would be the best way to add a simple new button (using a bbcode already existing) ?

For example a spoiler button using the [spoiler][/spoiler] bbcode

Based on the discourse commit and @cpradio plugin, I have something like that :

/assets/javascripts/discourse/initializers/spoiler.js.es6

import { onToolbarCreate } from 'discourse/components/d-editor';

onToolbarCreate(toolbar => {
  toolbar.addButton({
    id: "spoiler-button",
    group: "extras",
    icon: "eye-slash",
    perform: e => e.applySurround('[spoiler]', '[/spoiler]', 'text')
    });
});

Is it a good start ?

1 Like
51

Thatā€™s pretty close. Are you getting an error or anything, if you have it on GitHub, I can pull it down and see if I can get it to work.

53

A little update, @cpradio made a plugin that works, I was able to add some buttons myself, itā€™s pretty easy if some people want to add theirs : GitHub - cpradio/discourse-plugin-spoiler-ui: Spoiler Composer Button for Discourse

Minor bug, I donā€™t know if itā€™s the composer or the plugin, but the spoiler bbcode doesnā€™t work on the preview, but works fine otherwise

Test

Also, not really a bug, but an observation. When we used an emoji (via the modal), the old editor added one space before and one after the emoji, not in the new one. Not really a problem though

edit : and finally, a little problem for european users, when we type the euro symbol (ā‚¬ - shortcut : ALT Gr + E) it also opens the emoji modal.

54

So I already submitted a PR for the link text, but I canā€™t recreate the other issues here on Meta, so Iā€™m not sure there is anything to fix. Might want to make sure you are on latest.

55

I think he means, when us use the quote button without any selected text, nothing appears in the text area.

Not really a problem for me, but I think thatā€™s what he meant.

For the code button, the default reaction was the 4 spaces, now itā€™s the one line version `'indent preformatted text by 4 spaces``. I prefer the new one personnally.

1 Like
57

Ah, didnā€™t notice that. I had only used it with selected text. :smile:

Yeah, unless you have text, then it preformats your selected text using the 4 spaces method (when multiple lines are selected, if the text is on a single line it seems to use code fences. ā€“ cool

58

I guess he means about (old) shortcuts on quotes, code and so on. But then he read this topic and he now understood why things are broken now. :smile:

When you guys will decide to normalize shortcuts with other editors, please compare to other markdown editors, not with editors in general (i.e. how the editor on stack overflow works?).

A small suggestion: please try to make a smart shortcuts for bold/italic. This means that if you press ctrl+i, you get the stars. If you start typing then press ctrl+i again another set of stars are inserted, when it should just skip the star.

See here a sample:

Mod edit: video link broken

59

Would be great if those things could be changedā€¦

1 Like
62

So whilst researching the quoted text button and list items only selecting the text that should change (which present a LOT of edge cases if you adjust them!)

I found this
https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/components/d-editor.js.es6#L339

It seems to reason that the line should actually read as this._selectText(sel.start + hlen, contents.length - hlen - tlen), for cases where the tailing tag being inserted is not the same length as the heading tag (think [spoiler]my test[/spoiler])

63

Itā€™s not possible to see the bottom of a topic anymore when the editor is visible. The new editor seems to be layered on top of the posts.

Itā€™s not really a big issue as long as the editor height is the same as the height of the suggested topics. But this is kinda annoying when I resize the editor or when there are no suggested topics (answering a private message).

4 Likes
64

Another little problem, if we type a long text, the scrolling in the preview doesnā€™t follow the scrolling in the composer. In the preview, if we donā€™t scroll manually, it stays at the beginning of the post.

1 Like
65

Markdown links appear to be broken:

e.g.:

[google](www.google.com)

google

(tested in Chrome, Firefox)

66

We used to extend blank onto the footer so you can always see everything regardless of size

67

No, it simply requires the http

[google](http://www.google.com)

google

3 Likes