Help us test the rewritten Composer

feature
68

Weird, I guess I never noticed that before. Thanks for clearing that up.

Issue resolved nonexistent. :smiley:

edit: I think I was just thrown off because the editor recognizes URLs without the http bit normally, e.g. www.google.com works fine.

69

@eviltrout:

Somewhat related to this topic: does the new composer help in any way regarding the possibility of having seamless embedded Discourse comments?

For reference see: https://meta.discourse.org/t/auto-assign-new-embedded-blog-topics-unique-categories/32036/10

73

I’m seeing the same erratic behavior in Chrome on the iPad too.

Here is a screenshot:

image.png2048×1536 149 KB

74

Chrome on iPad is not really a supported platform, mainly because chrome on iPad has insane quirks that no desktop or android version of chrome shares… it is a platypus, and not the good kind.

75

Why We Can’t prefomate XML as code

declare @id int = :id 
  if  @id < 0
  begin

select CONVERT(Bit,1) end as Valid,‘ales goot’ as Msg

  end
  else 
  begin
  select
  CASE when status='P' then CONVERT(Bit,0) else CONVERT(Bit,1) end as Valid
  ,'Temeljnica je već proknjižena!' as Msg
  from
  fin_doc d
  where
  id =  :id
  end

</SQL>
</sequence>
77

@eviltrout did a bit of debugging on mobile…

.d-editor-preview is still being refreshed after every keypress with cooked html of the post despite not being visible on screen. Editor should simply have a “no-preview” mode where Markdown is never cooked.

Ideally we should get away without even loading the Markdown parser js bundle until we start previewing Markdown.

This is causing lag on slow Android phones now.

2 Likes
78

I’d removed the body padding feature because I thought it was causing issues on the iPad but it seems it was a red herring. I’ve put it back:

https://github.com/discourse/discourse/commit/b05f6ddbe135988c45314a08010d928d919e96e9

2 Likes
79

I looked at the over refreshing of the preview. It looks like there was a bug with the new editor and it wasn’t debouncing every 30ms like it should be. I fixed that:

https://github.com/discourse/discourse/commit/fa27f0a2ea5046a1193d2edba1d97988e87cd455

We can’t stop rendering HTML though, as a bunch of code paths assume the HTML needs to be there as a shortcut to getting “cooked” content.

1 Like
80

This was a regression of mine. The code for doing this was patched into pagedown and I didn’t notice it!

Fixed here:

https://github.com/discourse/discourse/commit/42bf8151b2a89ac2b770b4c716ce4915bd69030d

2 Likes
81

Its looking a bit better on my doogy phone, don’t feel the lag as much

1 Like
82

The composer has some issues when you have a gifv in the post you’re writing (e.g. in the bug thread I just made). In the preview, the video reloads every time I type something, jumping back up to the top of the preview. This can cause the browser to hang if I type a full sentence fairly quickly or sometimes selecting text.

On Chrome/Win7/Desktop. Can repro while editing the aforementioned thread. Most noticeable when composer height is smaller than gifv height, made writing that post rather difficult. :slight_smile:

83

Functionally, the new composer works well.

My only little, piccolo, gripe is that it still uses a lot of absolute positioning making it tedious to re-arrange / re-style.

It took me a little while to get the re-arrangement below looking neat again after this update (still a bunch of little tweaks to be made).

Maybe a little less absolute positioning in the future? :wink:

But otherwise, good job.

Screen Shot 2015-11-10 at 7.45.55 PM.png2044×456 41.8 KB

4 Likes
84

That is an … interesting arrangement.

85

On meta, the ipad keyboard fix works for New Topic posting, but not reply posting.

86

I’m on iPad Air (iOS 9.1) and I can not select category for New topic.

1 Like
87

The euro symbol is still a bit of a problem on azerty keyboards, is there a way to deactivate some shortcuts ?

88

Okay I’ve committed a couple more iPad fixes. Safari on iOS is quickly becoming my worst enemy :smile:

I just removed the shortcut. I figure emoji doesn’t really need a shortcut anyway since you can just type :

https://github.com/discourse/discourse/commit/ff85fa2a98b71a132b0856b175c57182e75d50b3

4 Likes
89

One thing I haven’t mentioned so far is the new keyboard shortcuts. I tried my best to copy the same keys that Gmail and Google Docs use. Our buttons don’t always have a 1:1 to theirs so sometimes I had to improvise a bit.

Another nice feature I copied from Gmail is the way they display the shortcuts on a Mac:

It uses the common glyphs that people are used to seeing on a Mac for their keys. On Windows, the same shortcut is displayed as “Ctrl + Shift + 9”

I would appreciate any feedback on the choices I made for the buttons. It’s definitely not too late to tweak the keys now.

4 Likes
90

I can’t tell whether this should go here or in the bug category, but I don’t see anything about the new editor in the bug category.

Reply-as-linked-topic is working fine here on meta, but in my install (1.5.0.beta4) when I do reply as linked topic, nothing is getting put into the editor, so it really behaves just like writing a new topic.

Similarly I thought that I saw something about the insert-a-link icon (or control-K) on the new editor not working, but I don’t see it now. In any case, it doesn’t work in my version, but does here.

These seem rather like show-stoppers. Will these fixes be coming our way soon?

91

I am not sure who handles updating your site, but those fixes are in the latest tests-passed branch of Discourse. If you are tracking that branch and update now you will get them.

2 Likes